Repository navigation
Fix welcome command for fish shells - #804
Open
M1nt-Ch0c0 wants to merge 1 commit into
Open
M1nt-Ch0c0 wants to merge 1 commit into
M1nt-Ch0c0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
With the welcome screen enabled, a WSL or Unix pane using fish receives a command fish can execute instead of a POSIX
if ... then ... fiexpression left at its prompt. Closes #803.Design / 设计边界
sh -c. The outer invocation is valid in fish, bash and sh; Windows PowerShell behavior is unchanged.Evidence / 验证依据
fish -n -c; the new command passed actual sh, bash and fish execution with and without fastfetch. An interactive fish PTY executed the new command and accepted subsequent input.rustc --testharness extracted from the production function and test (the harness supplies a temporary-directory helper). It exercises the real shell commands; fish and bash are skipped when absent.python scripts/check_architecture.py --base origin/main: passed.python -m unittest scripts.tests.test_architecture_budgets scripts.tests.test_architecture_dependencies scripts.tests.test_architecture_governance: 55 passed.git diff --check: passed. Full Cargo product build and project test suite were not run: the pinned Rust 1.97.1 toolchain was not available locally. CI must verify the full product and native platforms.Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.python scripts/check_architecture.py --base origin/mainpasses; budgets were not inflated to fit the change.