Skip to content

chore(test): fix sample-rendering.e2e.ts and layers.e2e.ts #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulHax merged 1 commit into from
Aug 27, 2025
Merged

chore(test): fix sample-rendering.e2e.ts and layers.e2e.ts #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
name: E2E Testing on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
env:
DOWNLOAD_TIMEOUT: 60000
DOWNLOAD_TIMEOUT: 90000
steps:
- uses: actions/checkout@v4
with:
Expand Down
10 changes: 5 additions & 5 deletions tests/pageobjects/volview.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class VolViewPage extends Page {
}

async getNotificationsCount() {
const badge = await this.notifications.$('span[aria-label="Badge"]');
const badge = this.notifications.$('span[aria-label="Badge"]');
const innerText = await badge.getText();
if (innerText === '') return 0;
return parseInt(innerText, 10);
Expand All @@ -94,7 +94,7 @@ class VolViewPage extends Page {
}

async activateRectangle() {
const button = await this.rectangleButton;
const button = this.rectangleButton;
await button.click();
}

Expand All @@ -119,16 +119,16 @@ class VolViewPage extends Page {
}

async saveSession() {
const save = await this.saveButton;
const save = this.saveButton;
await save.click();

const input = await this.saveSessionFilenameInput;
const input = this.saveSessionFilenameInput;
const id = getId();
const fileName = `${id}-session.volview.zip`;

await setValueVueInput(input, fileName);

const confirm = await this.saveSessionConfirmButton;
const confirm = this.saveSessionConfirmButton;
await confirm.click();

cleanuptotal.addCleanup(async () => {
Expand Down