Skip to content

Cancel native KCL tasks with Python callers - #13859

Draft
JordanNoone wants to merge 1 commit into
mainfrom
codex/cancel-native-kcl-task
Draft

Cancel native KCL tasks with Python callers#13859
JordanNoone wants to merge 1 commit into
mainfrom
codex/cancel-native-kcl-task

Conversation

@JordanNoone

Copy link
Copy Markdown
Contributor

Cancelling a Python KCL call dropped its waiter but left the spawned native task running. Abort that task when spawn_py is dropped so cancellation reaches native execution and releases its owned connection.

Addresses #13858. The regression fails on main and passes with this change. A separate check through the real Python binding and a local fake Engine reproduced a surviving socket and heartbeat before the fix; afterward the socket closed in approximately 1 ms with no further messages. Real Engine geometry interruption and GPU release remain unverified.

@vercel

vercel Bot commented Sep 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Sep 13, 2026 9:14am UTC

Request Review

@JordanNoone
JordanNoone force-pushed the codex/cancel-native-kcl-task branch from c82415b to 94ba891 Compare September 13, 2026 09:03
@codspeed-hq

codspeed-hq Bot commented Sep 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 150 untouched benchmarks
⏩ 128 skipped benchmarks1


Comparing codex/cancel-native-kcl-task (94ba891) with main (081a5bf)2

Open in CodSpeed

Footnotes

  1. 128 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (9b0eced) during the generation of this report, so 081a5bf was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant