Cancel native KCL tasks with Python callers - #13859
Draft
JordanNoone wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JordanNoone
force-pushed
the
codex/cancel-native-kcl-task
branch
from
September 13, 2026 09:03
c82415b to
94ba891
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling a Python KCL call dropped its waiter but left the spawned native task running. Abort that task when
spawn_pyis dropped so cancellation reaches native execution and releases its owned connection.Addresses #13858. The regression fails on main and passes with this change. A separate check through the real Python binding and a local fake Engine reproduced a surviving socket and heartbeat before the fix; afterward the socket closed in approximately 1 ms with no further messages. Real Engine geometry interruption and GPU release remain unverified.