Fix to preserve comments within call expressions when auto-fixing - #12463
Draft
jtran wants to merge 2 commits into
Draft
Fix to preserve comments within call expressions when auto-fixing#12463jtran wants to merge 2 commits into
jtran wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jtran
force-pushed
the
jtran-fix-comments-PR2-lint
branch
from
July 15, 2026 23:42
db3fef4 to
e4fa08d
Compare
jtran
force-pushed
the
jtran-fix-comments-PR2-lint
branch
from
July 16, 2026 22:34
e4fa08d to
aa7d574
Compare
|
Deployment failed with the following error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12481.
Stacked on #12062.
In addition to the Rust side fix #12454, this ended up being more involved than I expected because the order of comments relative to arguments needed to be preserved.