Fix clone point-and-click edge references - #12440
Closed
pierremtb wants to merge 18 commits into
Closed
Conversation
…point-and-click-cant-fillet-on-a-cloned-body
…point-and-click-cant-fillet-on-a-cloned-body
…llet-on-a-cloned-body
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…llet-on-a-cloned-body
pierremtb
commented
Jul 15, 2026
pierremtb
left a comment
pierremtb
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review notes
pierremtb
marked this pull request as ready for review
July 15, 2026 22:51
Contributor
Author
|
Marking as draft for now, #12473 might take over |
pierremtb
marked this pull request as draft
July 21, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12420 and #12421, through a big Codex pass at centralizing how edge selections resolve their owning body.
Suggested review order:
tagManagement.ts: core change. ReviewresolveEdgeSelectionContextand clone face mapping:edges.ts: Fillet, Chamfer, and Blend now use that shared context:sweeps.ts: edge-profile Extrude and edge directions use the same resolution path.Tests: the focused integration tests show the complete expected KCL for cloned Fillet, original-body Fillet, Blend, Profile GDT, and edge-profile Extrude. Playwright changes update existing expectations for qualified cap references.
Important notes:
cube2.sketch.tags.line2andcube2.faces.capEnd001.cube1.faces.capEnd001, even when a clone follows it.