Bump ezpz to 0.2.28 - #12431
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8d388e9 to
401de8c
Compare
eb463be to
bcfc8cb
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
| line1 = line(start = [var 0, var 0], end = [var 10, var 0]) | ||
| line2 = line(start = [var 0, var 0], end = [var 0, var 10]) |
There was a problem hiding this comment.
We were getting a false positive on this one before - lines were the same before and after the solve. Ezpz changes just surfaced it.
| // NOTE: Current LinesAtAngle constraint collapses if lines are initialized perpendicular to | ||
| // one another because the gradient of the residual has no tangential component in this | ||
| // configuration. The only path to reducing the residual is shrinking the lengths of the | ||
| // lines which causing the lines to collapse, producing a degenerate output. | ||
| let initial_source = "\ | ||
| sketch(on = XY) { | ||
| line(start = [var 0, var 0], end = [var 10, var 0]) | ||
| line(start = [var 0, var 0], end = [var 0, var 10]) | ||
| line(start = [var 0, var 0], end = [var 10, var 10]) |
There was a problem hiding this comment.
Worth flagging: LinesAtAngle is prone to collapse when initial conditions are pi/2 from the target angle and the lengths of the lines aren't otherwise constrained. Planning to address this in the next ezpz release.
|
Ok I think I've gotten as far as I can with addressing cargo test failures for now. We've got 4 remaining failures that seem to be hitting a similar issue: sketches are converging on the same shape within ezpz tolerance ( Not entirely sure how to proceed from here. Seems like it could take some time to resolve these but we're effectively blocked on ezpz updates until we do. fillet_ambiguous_region_edge_specifier/fillet_ambiguous_region_edge_specifier_broadSketch solves to the same shape on 0.2.28 within tolerance (max coord delta is fillet-ambiguous-region-2-28.mp4fillet-ambiguous-region-2-26.mp4fun_stacker_toySketch solves to the same shape on 0.2.28 within tolerance (with the exception of circle start anchors which differ up to
Related issue: https://github.com/KittyCAD/toolpaths/issues/431 sheet_metal_bracketSketch solves to the same shape on 0.2.28 within tolerance with the exception of a small handful of coords whose diff is between
|
Constrain circle seam orientations in configuration that results in successful CSG
|
FYI can ignore failure on |
|
Update: |
jtran
left a comment
There was a problem hiding this comment.
Please merge main to not miss new tests added.
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>





No description provided.