Repository navigation
docs(app): document per-route state instead of claiming the flows are done - #29
Merged
Merged
Conversation
… done "Send, claim, decline and lock-detail work end to end" overstated it: /payee and /attester are stubs, the Playwright e2e is still fixme, and there is no rate provider so displays are USD-only. List each route's real state and the rules the repo enforces (chain-is-truth, fragment never leaves the browser, no hard-coded country).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The README said "Send, claim, decline, and lock-detail flows work end to end against testnet." That is ahead of reality on three counts:
/payeeand/attesterare stubs, the Playwright e2e is stilltest.fixme, and there is no rate provider. Overstating status in the repo a contributor reads first is the worst place to be wrong.Changes
/,/request,/send,/claim/[id],/locks/[id],/r/[txHash]/[eventIndex],/verify) and/payee//attestermarked as stubs with their rows (M3-11,M3-12).M3-06in progress, e2e not yet enabled, USD-only display with a note whileM3-16is open, Phase 4 at 11 DONE / 6 IN PROGRESS / 9 TODO.proxy.tsnonce CSP on/claim/*, site-wideReferrer-Policy: no-referrer,nosniff,X-Frame-Options: DENY, zero third-party scripts, claim links only inlocalStoragewith export); amounts shown honestly throughAssetLabel/AmountDisplay/DateTimeDisplaywithRateProviderfailing closed; no hard-coded country (messages/en.json, an inline-string guard test,Intl); and onlylib/sdk.tstalks to the contract, with wallets behind Stellar Wallets Kit.lib/payees/known.tscaveat: three testnet fixture payees (KE, NG, PH) re-derived and matched against livegetPayee; status and payout always come from chain; the deployed app currently runs withoutNEXT_PUBLIC_INDEXER_URL.vercel --proddeploy caveat.Hard rules / invariants touched
3 (chain is truth), 5 (no personal data / claim fragment never reaches a server), 7 (honest wording), 11 (country-agnostic core). Documentation of existing enforcement; no behavior change.
Tests
Docs only. Route list from the app router directory; the CSP and header rules from
proxy.ts; the component names fromcomponents/; the fixture payees andgetPayeecross-check fromlib/payees/known.ts;test.fixmeand the missing rate provider verified by reading the e2e spec andRateProvidercall sites. I did not runpnpm e2eorpnpm devfor this PR, since nothing executable changed.Docs / ADR
README.mdonly. No ADR.Roadmap
No row changes. Changelog entry added (2026-10-08,
docs/readme-refresh, app).Assumptions and open questions
origin/main; the unmerged feature branch is not stacked here.