Repository navigation
feat: favicon, site header with docs/GitHub links, mobile nav, hero motion - #25
Merged
Merged
Conversation
…otion - app/icon.svg, app/apple-icon.png: favicon and iOS home-screen icon from the org's new lock mark (kinlock-icon/). - components/nav/SiteHeader.tsx: persistent header across every page. Desktop: brand, primary nav (Send/Request/Verify), and two separately-styled, separately-destined buttons (outline Documentation -> kinlock-org.github.io, filled-neutral GitHub -> github.com/Kinlock-Org). Collapses to a hamburger disclosure menu below md, closes on route change and Escape. - Fixed the landing page footer's stale "How it works, in detail" link, which pointed at a raw GitHub markdown file instead of the real docs site. - globals.css: a strong --ease-out token (animate skill) used by the mobile menu's entrance and a staggered hero fade/slide-up on the landing page, both gated under prefers-reduced-motion. No new dependency: pure CSS, following the animate skill's "cheapest tool that works" rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Four fixes to the live app's public-facing polish: no favicon/app icon, no way to reach the docs site or GitHub repos except a buried footer link, no mobile navigation (nothing collapsed, nothing to collapse), and no motion anywhere on the site.
Changes
app/icon.svg,app/apple-icon.png: favicon and iOS home-screen icon, from the org's new lock mark (kinlock-icon/icon.svg/icon-light-1024.png).components/nav/SiteHeader.tsx: a persistent header on every page (wired intoapp/layout.tsx). Desktop: brand mark, primary nav (Send / Request / Verify), and two buttons styled differently on purpose since they go to different places: an outline "Documentation" button tokinlock-org.github.io, and a filled-neutral "GitHub" button togithub.com/Kinlock-Org. Belowmd, both collapse into a hamburger disclosure menu (morphing icon, closes on route change and on Escape).ARCHITECTURE_ESSENTIALS.mdfile on GitHub instead of the actual hosted docs site.emilkowalski/skillsanimateskill (Emil Kowalski's animation philosophy:animations.dev) and used it for two motivated, CSS-only animations: the mobile menu's entrance, and a staggered fade/slide-up on the landing page hero (headline, subtext, CTA). Both are plain CSS@keyframes, no new npm dependency, and both degrade to near-instant underprefers-reduced-motion.Hard rules / invariants touched
None. UI/navigation/styling only; no SDK calls, no money-moving logic touched.
Tests
pnpm lint,pnpm typecheck,pnpm test(93/93, including the inline-strings guard scanning the new component) andpnpm buildall green. Visually verified with Playwright screenshots: desktop nav, mobile closed/open hamburger states, and dark mode (all checked, not just built).Docs / ADR
None needed.
Roadmap
New row
M3-25added (app, P2,DONE): favicon, header/nav, mobile menu, reduced-motion-safe entrance motion. Phase 4 App: 9→10 DONE, total 24→25 (38%→40%). All rows: 39→40 DONE, total 199→200 (22%→23%). Changelog entry added.Assumptions and open questions
The GitHub org avatar (profile picture) itself isn't set here: there's no
gh/API command to upload it, and it's an account-level change outside this repo. Recommended file:kinlock-icon/icon-light-1024.png(opaque, matches the brand'spapertoken). Needs a human to upload it via the org's GitHub settings page.