Repository navigation
fix(app): copy review, em-dash and jargon fixes (M3-20) - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Copy review of every string in messages/en.json against hard rule 7 (honest wording) and plain-language rules, per issue #16 / roadmap M3-20.
Changes
Hard rules / invariants touched
None. Copy only, no logic changes.
Tests
pnpm lint, pnpm typecheck, pnpm test (79/79) all green.
Docs / ADR
None needed.
Roadmap
M3-20: TODO -> IN PROGRESS. Changelog entry added: yes.
Assumptions and open questions
Not closing issue #16: pages.receipt/pages.verify are still stub titles since M3-13 isn't built yet, so there's no receipt/verify copy to review. This PR covers everything that currently exists.