Spreadsheet Import stored procedure enhancement - #220
Open
guymaness2 wants to merge 10 commits into
Open
Conversation
added 9 commits
July 22, 2026 15:11
guymaness2
commented
Jul 30, 2026
| RAISERROR('Importing phone numbers...', 0, 10) WITH NOWAIT; | ||
|
|
||
| DECLARE @PhoneTypeDefinedTypeId INT = (SELECT TOP 1 [Id] FROM DefinedType WHERE [Guid] = '8345DD45-73C6-4F5E-BEBD-B77FC83F18FD'); | ||
| DECLARE @HomePhoneTypeId INT = (SELECT TOP 1 [Id] FROM DefinedValue WHERE [Guid] = 'AA8732FB-2CEA-4C76-8D6D-6AAA2C6A4303'); |
Contributor
Author
There was a problem hiding this comment.
Rename HomePhoneTypeId to HomePhoneTypeValueId
guymaness2
commented
Jul 30, 2026
|
|
||
| -- Best-effort formatted number for the default country code | ||
| UPDATE #phoneImport | ||
| SET NumberFormatted = CASE |
Contributor
Author
There was a problem hiding this comment.
Is formatted phone number required, or should we skip it and let Rock clean it up?
guymaness2
commented
Jul 30, 2026
|
|
||
| CREATE TABLE #newPhones (PhoneNumberId INT, PersonId INT, NumberTypeValueId INT, NumberFormatted NVARCHAR(50)); | ||
|
|
||
| INSERT PhoneNumber (IsSystem, PersonId, CountryCode, Number, NumberFormatted, NumberTypeValueId, IsMessagingEnabled, IsUnlisted, FullNumber, [Guid], CreatedDateTime, ModifiedDateTime) |
Contributor
Author
There was a problem hiding this comment.
Can we add phone numbers without messing with NumberFormatted and FullNumber?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your code contribution, we will take your code suggestion into consideration. It will be reviewed, and based on code quality and need addressed, we will determine acceptance. If this code addresses a feature request or issue, be sure to link to that issue.
Description
What does the change add or fix?
[Add a description here]
New Settings:
[Add a bulleted list of new settings here]
Release Notes
What does the change add or fix in a succinct statement that will be read by clients?
[Add a bulleted list of release notes here]
Requested By
Who reported, requested, or paid for the change?
[Add the client here]
Screenshots
Does this update or add options to the block UI?
[Add a screenshot here]
Change Log
What files does it affect?
[Add a file list here]
Migrations/External Impacts
Is it a breaking change for other versions/clients?
[Add a no or yes with explanation here]