Repository navigation
Conversation
…aceholder - Move the shared status words into `common` (common.running, common.completed) with each catalog's existing text; the code-reviewer list and detail screens point at them. - Map the subagent card's task state to common.pending, common.running, common.completed and common.failed, and pass the resolved label to the badge and to the card's accessibility label instead of the raw state token. - Give the slash-command Agent field its own placeholder (profiles.slashCommands.agentPlaceholder, "reviewer") so it shows an example agent identifier rather than the localized mode name. Allowlist it with the other literal example values. - Pin the localized status label, including a Hungarian case, in the mounted card suite.
iscekic
added
drain
|
bot: Android 15 emulator, app language Hungarian, local dev stack on this VM. Exercised: Profiles → Slash commands → Add. The Agent field renders The screenshot is the add-command sheet from that run, captured after an accessibility dump of the same screen with the field texts above.
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commit is a single refactor that derives Files Reviewed (2 files)
Incremental review of Previous Review Summaries (2 snapshots, latest commit 2d24426)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 2d24426)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe incremental commit is test-only and consistent with the localized status labels; the only remaining suggestion is the hand-copied Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (4 files)
Incremental review of Fix these issues in Kilo Cloud Previous review (commit 208ca99)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe localization change is consistent across all 87 catalogs and the renamed status paths have no stale references; the only finding is a copied status union that should be derived from the SDK type. Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (95 files)
Verified mechanically: every catalog moves the identical Reviewed by deepseek-v4.1-flash-1017 · Input: 37.3K · Output: 2.3K · Cached: 323.8K Review guidance: REVIEW.md from base branch |
The remaining child-card assertions built the expected text and the accessibility label from the raw task state; point them at the same catalog keys the card renders.
The card's status union is the SDK's own state union, so read it from ToolPart instead of restating the four literals. Also format the child-card test that the mobile format check flagged.
iscekic
added
merge:human
|
bot: Android 15 emulator, app language Hungarian, local dev stack on this VM. Exercised: Agents → Session history → a locally seeded agent-chat transcript that carries three subagent The screenshot is that transcript, captured from the same screen as the accessibility read.
|
This branch has not been deployed
2 participants
bot:
What changes
The subagent card in agent chat now draws and announces its task state from the catalog instead of the raw task-state token, and the slash-command form's Agent field shows an example agent identifier.
common.runningandcommon.completedjoin the generic state words already incommon(pending,queued,failed,cancelled). Their per-locale text moves unchanged fromcodeReviewer.status.*, and the code-reviewer list and detail screens now point at thecommonkeys.child-session-section.tsxmaps the card's state tocommon.pending/common.running/common.completed/common.failed, and passes the resolved label both to the badge and toagentChat.childSession.accessibilityLabel, so the announcement keeps the five interpolations the catalogs define.profiles.slashCommands.agentPlaceholder(reviewer) instead of borrowingagentChat.modeOptions.code; the literal example is allowlisted alongsidenamePlaceholder, so the field shows an identifier in every language.child-session-section.mounted.test.tsxasserts the localized badge label for every state and adds a Hungarian case that pins both the badge text and the accessibility label.Verification
Catalog and suite checks on this VM:
Android 15 emulator, app language Hungarian, local dev stack (
localhost):reviewer, while the surrounding fields stay Hungarian (A parancs neve/explain,Sablon/Magyarázza el $ARGUMENTS). Previously this field showedKódolás, the localized mode name. Attached screenshot shows the form.Fut,BefejezveandSikertelen, and the running card's accessibility label readsResearcher, Hozzáférési szabályok ellenőrzése, Gondolkodás, Fut, so the announcement ends in the same Hungarian status word. The mounted suite covers the same states directly: it mounts the realChildSessionSectionagainst the real SDK jotai storage and switches the real i18n instance tohu.Proxy answers
The owner's proxy gave these answers in the owner's place.
Answer: Move Running/Completed into common.*
Confidence: 0.70 · Precedent: Replace old paths instead of keeping them alongside: session ad6a3f589364, "alongside? why not instead?"; fix the class: session 00eb2a1d3e4b, "fix the class"
Answer: code
Confidence: 0.55 · Precedent: none
Answer: common.failed ("Failed")
Confidence: 0.75 · Precedent: Keep similar elements consistent across surfaces: session a247f3c19b1e, owner asked that the thought row match the tool call row
Answer: Dedicated key, "reviewer"
Confidence: 0.75 · Precedent: Keep CI checks that catch real errors: "we want to catch errors in PRs, as early as possible" (session 99e88001c4b4). Weakening the one-wording check with 84 exceptions goes against it, and the brief asks for a dedicated key with an example identifier.