Repository navigation
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental change re-arms an alarm for a Files Reviewed (3 files)
Previous Review Summary (commit 7f8e0c2)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 7f8e0c2)Status: 1 Issues Found | Recommendation: Address before merge Executive SummaryThe downloaded-startup path (trusted release preflight, scoped artifact grant, bounded bootstrap report) is well-guarded; the one concern is that a native allocation stopped while a create is still in flight no longer has a durable restart if the in-flight create is lost to a Durable Object eviction, risking a late Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Files Reviewed (27 files)
Reviewed by deepseek-v4.1-flash · Input: 72.1K · Output: 18.2K · Cached: 1.2M Review guidance: REVIEW.md from base branch |
Native Cloud Agent allocations can select
downloadedstartup independently of the native image. The Worker validates a trusted release before allocation, issues a short-lived two-object grant, and supplies one bootstrap command for both repository restore and image fallback. Default startup remainspreinstalled.Startup failures use the current signed launch binding. Permanent artifact/probe failures fail preparing routes promptly; retryable failures keep the existing preparation deadline. Both report/provider race orders, credential rotation, persisted startup mode and snapshot keys have integration coverage. Stopped retryable allocations retain the existing retry alarm. After Durable Object reconstruction, that alarm resumes work with the same route attempt and deadline. No persisted state or provider polling was added. Native PID1 diagnostics redact bootstrap arguments.
Validation: 498 initial focused unit tests passed. After the retry-recovery fix, 40 focused unit tests and 264 Worker integration tests passed, including a forced-reconstruction regression. Typecheck, service lint, repository formatting and Markdown checks passed. Local native preinstalled and downloaded cold starts plus three warm messages passed. Native HTTPS allowlist downloads and a denied-host control passed. Unauthorized download failed in 8.4 seconds and produced the specific session-stream error.
Local native A-to-B snapshot restore passed: B ran, A's start counter stayed one, and user configuration, files and an executable dependency remained. Wrangler changes local image tags on restart, so this test used a controlled snapshot-index fixture after verifying the unchanged image digest. It does not prove production snapshot reuse across deployment.
Real-provider qualification and production rollout belong to later approved gates. No production target selects downloaded startup. Native HTTPS CLI-probe failure also passed in 20.6 seconds with the correct stream error. Dropped startup reports retained the existing five-minute first-connect retry and 12-minute preparation timeout; the final timeout appeared in the stream. All temporary public tunnels are closed.
Stack: #7915 → #7917 → this PR. Base:
eshurakov/ca-runtime-release-format.