Repository navigation
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe change records the allocation's start image on the containers record and keys repository captures with it instead of the current configured image; the storage, start, resume, and capture paths are consistent, and the new tests cover the image-change and legacy-record cases. Files Reviewed (3 files)
Verification notes
Reviewed by deepseek-v4.1-flash · Input: 74.9K · Output: 13.9K · Cached: 1M Review guidance: REVIEW.md from base branch |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository capture used the current configured image for its key. A container kept running across an image change could publish its old filesystem under the new image key.
Record the selected image before native start. Use that stored image for capture after reconstruction or deployment. Legacy running records without an image skip capture until their next allocation.
Verification
No manual provider test ran. No real provider target is authorized. The local regression reproduces the wrong key before the fix and observes the stored KV key after the fix.
Visual Changes
N/A
Reviewer Notes
Independent B1 prerequisite for runtime rollout step 2. Base: main. This PR must merge before runtime-free image qualification.
Automated checks: 210 container tests passed; Worker and wrapper typecheck passed; focused lint, formatting, and diff checks passed. The image-change regression includes Durable Object reconstruction. Real Cloudflare image rollout and snapshot behavior remain provider acceptance work.