[Color][Image] Update modal background to embedded content token - #4103
Open
Myranae wants to merge 6 commits into
Open
[Color][Image] Update modal background to embedded content token#4103Myranae wants to merge 6 commits into
Myranae wants to merge 6 commits into
Conversation
…ed content token Also remove an extra background color that was interfering with the modal background
…get modal background to stay dark across themes
Contributor
npm SnapshotWant to try this PR's changes before it merges? Comment |
Contributor
|
Size Change: +25 B (0%) Total Size: 519 kB 📦 View Changed
ℹ️ View Unchanged
|
Myranae
commented
Aug 20, 2026
Myranae
marked this pull request as ready for review
August 20, 2026 17:11
Myranae
requested review from
catandthemachines,
ivyolamit and
nishasy
as code owners
August 20, 2026 17:11
…or transparent images
…img element This is to allow us to apply the styling to a not img element (which gets affected by the inversion filter)
The new rule is just to add the background for use behind images in the modal
Myranae
commented
Aug 21, 2026
| /> | ||
| )} | ||
| </AssetContext.Consumer> | ||
| <div className={styles.modalImageBackground}> |
Contributor
Author
There was a problem hiding this comment.
This line is the only difference here, but it moved the rest down. Also added the closing div at the bottom I suppose
Myranae
commented
Aug 21, 2026
| max-height: var(--perseus-image-modal-panel-height); | ||
| } | ||
|
|
||
| .modal-image-container img { |
Contributor
Author
There was a problem hiding this comment.
This style rule just got moved down and the background color got moved to its own styling rule based on a new class added above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Uses the new embedded content token on the image modal background.
Issue: LEMS-4462
Test plan: