[Static:Perseus] Remove static from WidgetOptions - #4072
Open
handeyeco wants to merge 5 commits into
Open
Conversation
handeyeco
changed the title
Contributor
npm SnapshotWant to try this PR's changes before it merges? Comment |
handeyeco
changed the title
static from WidgetOptions
github-actions
Bot
added
item-splitting-change
schema-change
handeyeco
added
schema-change-ack
Contributor
|
Size Change: -74 B (-0.01%) Total Size: 519 kB 📦 View Changed
ℹ️ View Unchanged
|
…`Perseus*WidgetOptions` since it was shadowed by `static` in `WidgetOptions` (the higher-level type). This has some large implications: types in `perseus-core` have changed and serialization in `perseus-editor` and `perseus` are also likely to change.
handeyeco
commented
Aug 13, 2026
| trackInteraction, | ||
| handleUserInput, | ||
| } = props; | ||
| const isStatic = props.static ?? false; |
Contributor
Author
There was a problem hiding this comment.
There was some weirdness with undefined and null (destructuring defaults undefined but not null)
handeyeco
marked this pull request as ready for review
August 13, 2026 15:54
jeremywiebe
approved these changes
Aug 13, 2026
jeremywiebe
left a comment
jeremywiebe
left a comment
Collaborator
There was a problem hiding this comment.
Cool! So nice to see this getting cleaned up!
handeyeco
changed the title
static from WidgetOptionsstatic from WidgetOptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Go parser part of this was released: https://github.com/Khan/webapp/pull/41461
See the ticket for more details, but the tl;dr:
staticinPerseus*WidgetOptionswas the result of poor serializationstaticinWidgetOptionsshadowsstaticinPerseus*WidgetOptionsIssue: LEMS-4476