Repository navigation
fix: add Vary: Origin so caches key CORS responses per-origin - #313
Merged
Gauravjeetsingh merged 1 commit intoOct 7, 2026
Merged
Conversation
Responses are cacheable (cacheControl maxAge 21600) and carry a per-origin Access-Control-Allow-Origin, but sent no Vary header. Shared caches therefore keyed only by URL, so a response cached under one origin was replayed to another origin on the same base domain (which share a browser cache partition), serving the wrong Access-Control-Allow-Origin and failing CORS. Varying on Origin makes caches store a copy per origin.
Gauravjeetsingh
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responses are cacheable (cacheControl maxAge 21600) and carry a per-origin Access-Control-Allow-Origin, but sent no Vary header. Shared caches therefore keyed only by URL, so a response cached under one origin was replayed to another origin on the same base domain (which share a browser cache partition), serving the wrong Access-Control-Allow-Origin and failing CORS. Varying on Origin makes caches store a copy per origin.