Report firmware version in Zcash batch results - #133
Merged
soralit merged 3 commits intoJul 14, 2026
Merged
Conversation
czarcas7ic
marked this pull request as ready for review
July 13, 2026 19:49
soralit
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a required three byte
firmware_versionvalue at CBOR key3on the existingzcash-batch-sig-resultregistry type. The SDK represents it as[u8; 3]for the raw[major, minor, build]version and rejects short or long encodings.The request type and opaque PCZT batch payload remain unchanged. New decoders intentionally reject old two field batch results so callers always receive the signing firmware version.
Validation:
cargo test -p ur-registry --locked(165 passed),cargo test -p ur-parse-lib --locked(17 passed), targeted formatting, andgit diff --check.