Conversation
Adds functionality for unlocking from local wifi
| my $name = $self->param('name'); | ||
| my $pin = $self->param('pin'); | ||
| my $remember = $self->param('remember'); | ||
| my $ip = $self->param('ip'); |
Contributor
Author
There was a problem hiding this comment.
This parameter was never created but never implemented into the program so it needs to be removed, because I found another way to do what I was trying to accomplish and never ended up using it.
|
|
||
| if($request->{authorized} == 1 || ($request->{authorized} == 2 && Date_IsWorkDay(ParseDate('now'), 1))) { | ||
| my $req = HTTP::Request->new(GET => "http://theofficialjosh.com/test"); | ||
| my $ua = LWP::UserAgent->new; |
There was a problem hiding this comment.
Don't use HTTP::Request or LWP::UserAgent when Mojo::UserAgent is already available to you for free.
|
This is really good! There's a few things that should really get some attention before merging, but all in all, this is really terrific!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates program so it also checks for dates when allowing the user to unlock or not
Updates program so user can run it as a command