Skip to content

fix(docker): flush config.json to the KSM record on container shutdown #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mani-muon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(docker): flush config.json to the KSM record on container shutdown #2405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,15 @@ start_config_monitor() {
# Stop config.json monitoring
stop_config_monitor() {
if [[ -f "${MONITOR_PID_FILE}" ]]; then
# Flush the latest config.json back to the KSM record before killing
# the monitor: the monitor only uploads on its MONITOR_INTERVAL tick,
# so a shutdown between ticks would otherwise lose any change written
# since the last tick (notably the clone_code refreshed on each login).
if [[ -n "${KSM_CONFIG:-}" || -n "${KSM_TOKEN:-}" ]] \
&& [[ -n "${RECORD:-}" ]] && [[ -f "${CONFIG_FILE}" ]]; then
upload_config_to_ksm "${KSM_CONFIG:-}" "${KSM_TOKEN:-}" "${RECORD}" || true
fi

local monitor_pid
monitor_pid=$(cat "${MONITOR_PID_FILE}")
if kill -0 "${monitor_pid}" 2>/dev/null; then
Expand Down