Skip to content

Improve LoadRecordTypes command - #2400

Open
lthievenaz-keeper wants to merge 1 commit into
Keeper-Security:releasefrom
lthievenaz-keeper:feat/improve-LoadRecordTypes
Open

lthievenaz-keeper wants to merge 1 commit into
Keeper-Security:releasefrom
lthievenaz-keeper:feat/improve-LoadRecordTypes

Conversation

@lthievenaz-keeper

Copy link
Copy Markdown
Contributor

Problems to resolve

  • The load-record-types command limits custom record type titles to 30 characters, but the limit is 32
  • The load-record-types command gets interrupted if the request to create a new record type fails due to invalid data.
    • This break has the side effect of not syncing the new custom record types, forcing a relog.

Changes

  • Imported custom record types titles are now the correct 32 character limit
  • Added try/except block to continue even if one custom record type is invalid
  • Added more verbose logging of successful additions
  • Added color coding for logging

Before

image

After

image

The load-record-types command gets interrupted if the request to create a new record type fails due to invalid data.

Added:
- try/except block to continue even if one custom record type is invalid
- more verbose logging of added custom record types
- color coding for new logging

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant