Repository navigation
Remove unused core:test dependency from app-tv and update architecture diagram - #355
Merged
Merged
Conversation
…e diagram app-tv:app declared core:test as a production implementation dependency, although app-tv has no tests that use its fixtures. Regenerate asset/architecture.jpg from the current module graph (transitive reduction of all api/implementation project dependencies), adding the app-tv, core:network:ktor and data:sqldelight modules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LdTSnHJuKJCMRBciY2JQ2F
Generated by 🚫 Danger Kotlin against 835103a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app-tv/app/build.gradle.kts: removesimplementation(core.test). It put the test-fixtures module on the production TV app's classpath, but nothing inapp-tvreferencescore_test, kotest or mockk.:app-tv:appalready declares:core:basedirectly, so it loses nothing. No replacement (testImplementation(testFixtures(...))) is added, becauseapp-tvhas no tests that use the fixtures.asset/architecture.jpg: regenerated from the current module graph. The README already points to this file, so it needs no changes.:app-tv:app,:app-tv:navigation,:app-tv:ui,:core:network:ktorand:data:sqldelight.:app-watch:appand:app-watch:ui.:data:market-repositorynow points to:domain:market, and:core:testnow points to:core:baseand:core:uimarket.api/implementationproject dependencies: 31 arrows out of 77 direct ones. A path between any two modules exists in the diagram exactly when it exists in the build files.:konsist(no project dependencies) and:baselineprofileare left out, as in the original.Checklist
./git-hooks/setup.shGradle was not run locally. CI will build the change.
No linked issue.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LdTSnHJuKJCMRBciY2JQ2F
Generated by Claude Code