Repository navigation
Remove unused core.test dependency from app-tv module - #354
Merged
Merged
Conversation
core:test exposes the Kotest bundle via api(), so implementation(core.test) shipped test libraries in the TV app's release runtime classpath. Nothing in app-tv uses it, and core.base/koin are already declared directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DjWxDEyd4U4HSQMvSv8oBi
Generated by 🚫 Danger Kotlin against 8de2e78 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes an unused
core.testdependency from theapp-tvmodule's build configuration.Changes
implementation(core.test)fromapp-tv/app/build.gradle.ktsDetails
The
core.testmodule provides shared testing utilities and is not needed as a runtime dependency in theapp-tvapplication module. Testing dependencies should only be included in test source sets when actually used for testing purposes, not as production implementation dependencies.This cleanup reduces the app-tv module's dependency footprint and aligns with proper dependency management practices.
https://claude.ai/code/session_01DjWxDEyd4U4HSQMvSv8oBi