VesselLabel.EnableAllLabels actually disables all labels

[Clayell]

Provide a description of the KSP bug or improvement

Came across this by chance in the ksp codebase, unsure if it actually breaks things ingame.

VesselLabel.EnableAllLabels() happens to have the exact same logic as VesselLabel.DisableAllLabels(), which perhaps seems to be a typo on behalf of squad. An Enable() method for BaseLabel does exist.

private void DisableAllLabels()
{
	int i = 0;
	for (int count = labels.Count; i < count; i++)
	{
		BaseLabel baseLabel = labels[i];
		if (baseLabel != null)
		{
			baseLabel.Disable();
		}
	}
}

private void EnableAllLabels()
{
	int i = 0;
	for (int count = labels.Count; i < count; i++)
	{
		BaseLabel baseLabel = labels[i];
		if (baseLabel != null)
		{
			baseLabel.Disable();
		}
	}
}

[Clayell]

Actually, this is kinda weirdly written.

private void LateUpdate()
{
	if (GameSettings.TOGGLE_LABELS.GetKeyDown())
	{
		GameSettings.FLT_VESSEL_LABELS = !GameSettings.FLT_VESSEL_LABELS;
		if (GameSettings.FLT_VESSEL_LABELS)
		{
			EnableAllLabels();
		}
		else
		{
			DisableAllLabels();
		}
	}
	if (GameSettings.FLT_VESSEL_LABELS)
	{
		ITargetable currentTarget = GetCurrentTarget();
		Vessel activeVessel = FlightGlobals.ActiveVessel;
		Vector3 activePosition = ((activeVessel != null) ? activeVessel.transform.position : Vector3.zero);
		int i = 0;
		for (int count = labels.Count; i < count; i++)
		{
			ProcessLabel(labels[i], activeVessel, currentTarget, activePosition);
		}
	}
}

This check here:

if (GameSettings.FLT_VESSEL_LABELS)
{
	EnableAllLabels();
}
else
{
	DisableAllLabels();
}

Is entirely redundant, and probably flawed. EnableAllLabels is suppsoed to enable all labels even if they're out of range. The next check would then immediately override that in ProcessLabel.
The enable vessel label hotkey works fine as is (I tested it ingame), so the best option is probably to patch the LateUpdate to entirely remove the calls to EnableAllLabels() and DisableAllLabels(). It would be pretty much impossible to see, but what I imagine what is happening right now is that all vessel labels become visible for a split-second while going between EnableAllLabels and ProcessLabels.