fix: remove remaining language attractor tokens - #817
Open
Mariomarquezt wants to merge 1 commit into
Open
Conversation
710173f de-named the language rule in skills/caveman/SKILL.md to stop "Portuguese"/"Spanish" example tokens attracting generation into the wrong language. Two injected copies of the same rule were missed and still carry the tokens on HEAD: - skills/caveman-help/SKILL.md:41 β the /caveman-help card, reported in JuliusBrussee#812. - src/hooks/caveman-activate.js:154 β the fallback ruleset used when SKILL.md is not found (standalone hook install without the skills dir). Not mentioned in the report, but it is injected at SessionStart exactly like the fixed file, so it reproduces the same drift for that install path. Both rewordings follow 710173f: state the rule without naming any language, and make the "regardless of example text elsewhere" clause explicit. caveman-help is not CI-mirrored under plugins/ (per CONTRIBUTING), so the top-level source is the only copy. README.md:137 also names the languages but is prose documentation, never injected into a session, so it is left alone. Fixes JuliusBrussee#812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #812.
Problem
710173fde-named the language rule inskills/caveman/SKILL.mdto remove thePortuguese/Spanishexample tokens that were pulling generation into the wrong language. Two other injected copies of the same rule were not touched and still carry the tokens onmain:skills/caveman-help/SKILL.md:41/caveman-helpis invoked β the site identified in #812src/hooks/caveman-activate.js:154SKILL.mdis not foundThe second one is not mentioned in the report. It is the fallback ruleset, and it is injected at SessionStart exactly like the file
710173ffixed, so it reproduces the same drift for that install path.Change
Both rewordings follow the shape
710173fused: state the rule without naming any language, and make the "regardless of example text elsewhere" clause explicit.Scope notes
caveman-helpis not CI-mirrored underplugins/(CONTRIBUTING, "not mirrored by CI" table), so the top-level source is the only copy. No sync gap to chase.README.md:137also names the languages, but it is prose documentation and is never injected into a session, so it is left alone.Verification
Full CI suite run locally on this branch:
npm testβ 125 passed, 0 failedtests/test_*.jsβ 169 passed, 0 failed across 8 filespython -m unittest discover -s testsβ Ran 58 tests, OK