Skip to content

fix: remove remaining language attractor tokens - #817

Open
Mariomarquezt wants to merge 1 commit into
JuliusBrussee:mainfrom
Mariomarquezt:fix/language-attractor-remaining-sites
Open

fix: remove remaining language attractor tokens#817
Mariomarquezt wants to merge 1 commit into
JuliusBrussee:mainfrom
Mariomarquezt:fix/language-attractor-remaining-sites

Conversation

@Mariomarquezt

Copy link
Copy Markdown

Fixes #812.

Problem

710173f de-named the language rule in skills/caveman/SKILL.md to remove the Portuguese/Spanish example tokens that were pulling generation into the wrong language. Two other injected copies of the same rule were not touched and still carry the tokens on main:

File Injected when
skills/caveman-help/SKILL.md:41 /caveman-help is invoked β€” the site identified in #812
src/hooks/caveman-activate.js:154 SessionStart, on a standalone hook install where SKILL.md is not found

The second one is not mentioned in the report. It is the fallback ruleset, and it is injected at SessionStart exactly like the file 710173f fixed, so it reproduces the same drift for that install path.

Change

Both rewordings follow the shape 710173f used: state the rule without naming any language, and make the "regardless of example text elsewhere" clause explicit.

-Keep user's language by default. User write Portuguese β†’ reply Portuguese caveman.
+Keep user's language by default β€” reply in the language user writes, never switch
+regardless of example text or multilingual context elsewhere.

Scope notes

  • caveman-help is not CI-mirrored under plugins/ (CONTRIBUTING, "not mirrored by CI" table), so the top-level source is the only copy. No sync gap to chase.
  • README.md:137 also names the languages, but it is prose documentation and is never injected into a session, so it is left alone.
  • No behaviour change beyond the rule text; no test asserted on the removed strings.

Verification

Full CI suite run locally on this branch:

  • npm test β€” 125 passed, 0 failed
  • tests/test_*.js β€” 169 passed, 0 failed across 8 files
  • python -m unittest discover -s tests β€” Ran 58 tests, OK

710173f de-named the language rule in skills/caveman/SKILL.md to stop
"Portuguese"/"Spanish" example tokens attracting generation into the wrong
language. Two injected copies of the same rule were missed and still carry
the tokens on HEAD:

- skills/caveman-help/SKILL.md:41 β€” the /caveman-help card, reported in JuliusBrussee#812.
- src/hooks/caveman-activate.js:154 β€” the fallback ruleset used when SKILL.md
  is not found (standalone hook install without the skills dir). Not mentioned
  in the report, but it is injected at SessionStart exactly like the fixed
  file, so it reproduces the same drift for that install path.

Both rewordings follow 710173f: state the rule without naming any language,
and make the "regardless of example text elsewhere" clause explicit.

caveman-help is not CI-mirrored under plugins/ (per CONTRIBUTING), so the
top-level source is the only copy. README.md:137 also names the languages but
is prose documentation, never injected into a session, so it is left alone.

Fixes JuliusBrussee#812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language drift: few-shot Portuguese/Spanish examples in SKILL.md leak into output despite fixed-language user instructions"

1 participant