fix(hooks): include caveman-parse.js in standalone installers - #806
Open
vishnujayvel wants to merge 1 commit into
Open
fix(hooks): include caveman-parse.js in standalone installers#806vishnujayvel wants to merge 1 commit into
vishnujayvel wants to merge 1 commit into
Conversation
HOOK_FILES in install.sh/install.ps1 omitted caveman-parse.js, which caveman-mode-tracker.js requires at load. Remote fallback URL also pointed at main/hooks instead of main/src/hooks (404). Fixes JuliusBrussee#801
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #801 (reported by @prpr289).
Standalone hook installers
src/hooks/install.shandsrc/hooks/install.ps1copied aHOOK_FILES/$HookFileslist that omittedcaveman-parse.js.caveman-mode-tracker.jstop-level-requires./caveman-parse, so a UserPromptSubmit hook installed via those scripts exits 1 on every prompt.Secondary bug in the same files: remote fallback base URL pointed at
.../main/hookswhile hooks live undersrc/hooks/— every remote fetch 404s.Changes (exactly two files)
src/hooks/install.sh— addcaveman-parse.jstoHOOK_FILES; setREPO_URLto.../main/src/hookssrc/hooks/install.ps1— addcaveman-parse.jsto$HookFiles; set$RepoUrlto.../main/src/hooksOut of scope (intentional)
cli/install.jsalready listscaveman-parse.jsand pins a ref (v1.10.0) with a checksum integrity gate. Not touched.checksums.sha256not touched.cli/install.jsdoes) is left to maintainer preference; this PR is the minimal fix for the broken file list + 404 URL.Shell installers remain a supported install path for users who run them directly; this keeps that path working.
Test plan
No automated tests cover
src/hooks/install.sh/install.ps1(reponpm testonly runstests/installer/*.test.mjsagainstcli/install.js). Manual repro + control is the coverage for this change.Repro (before fix — old file list, no
caveman-parse.js)Observed (Node v26.5.0):