Handle Julia 1.12 expressions with multiple semicolons - #53
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 97.41% 97.46% +0.05%
==========================================
Files 6 6
Lines 232 237 +5
==========================================
+ Hits 226 231 +5
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oxinabox
reviewed
Aug 14, 2026
| def[:kwargs] = ex.args[i].args | ||
| def[:kwargs] = Any[] | ||
| for arg in ex.args[i].args | ||
| if arg isa Expr && arg.head === :parameters |
Member
There was a problem hiding this comment.
Suggested change
| if arg isa Expr && arg.head === :parameters | |
| if Meta.isexpr(arg, :parameters) |
I am surprised that isn't used more in here?
Member
Author
There was a problem hiding this comment.
We should probably update this code to use Meta.isexpr. I'll leave it as I wrote it though so that everything is consistent. We can do a follow up PR for that change.
oxinabox
approved these changes
Aug 14, 2026
omus
force-pushed
the
cv/julia-1.12-compat
branch
from
August 14, 2026 09:43
93ffad0 to
69b79e9
Compare
Member
Author
|
I'll leave the fix for the nightly failure out of this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43. In Julia 1.12 the way the expression
(x; y; z) -> 0differs from older versions of Julia:Julia 1.12.6:
Julia 1.11.9
This syntax isn't a valid function so I've updated the code to detect this as an invalid definition.