Fix symv!/hemv! and symm!/hemm! dispatch for unsupported eltypes.#577
Merged
Conversation
generic_matvecmul! dispatched Symmetric inputs to symv! and Hermitian inputs to hemv! whenever the eltype was a BLAS float, but oneMKL only wraps symv! for real eltypes and hemv! for complex ones. Guard the branches accordingly: complex Symmetric falls through to generic_matmatmul! (which can use symm!), and real Hermitian uses symv! since a real Hermitian matrix is symmetric. Similarly, the symm!/hemm! branches in generic_matmatmul! lacked any eltype or stridedness guards, and hemm! is only wrapped for complex eltypes; add the missing guards and route real Hermitian to symm!. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
CI seems broken here. I tested this locally, let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generic_matvecmul! dispatched Symmetric inputs to symv! and Hermitian inputs to hemv! whenever the eltype was a BLAS float, but oneMKL only wraps symv! for real eltypes and hemv! for complex ones. Guard the branches accordingly: complex Symmetric falls through to generic_matmatmul! (which can use symm!), and real Hermitian uses symv! since a real Hermitian matrix is symmetric.
Similarly, the symm!/hemm! branches in generic_matmatmul! lacked any eltype or stridedness guards, and hemm! is only wrapped for complex eltypes; add the missing guards and route real Hermitian to symm!.