Fix type usage in opnorm for AbstractGPUSparseMatrixCSC - #747
Merged
Conversation
Member
Author
|
The other possible fix is to add a dispatch to |
kshyatt
force-pushed
the
ChrisRackauckas-patch-1
branch
from
August 13, 2026 07:20
d7d6af3 to
151d85c
Compare
Member
|
Fails look related now |
Member
|
@kshyatt This function is defined according to the definition in the GPUArrays readme in CUDA.jl (takes in the array type), but not JLArrays (takes in the array), but it's used as defined in JLArrays in mapreduce GPUArrays.jl/src/host/sparse.jl Lines 1009 to 1012 in b94388f I suggest we fix this in JLArrays and define |
Member
|
Sounds good, should we do this in this PR? |
Member
Yeah I'll push |
christiangnrd
force-pushed
the
ChrisRackauckas-patch-1
branch
from
August 13, 2026 12:13
bbc4e20 to
639b5bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It requires a type not a value.
Found in https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/28556241206/job/84664223984?pr=3810#step:11:516