Allow exact reproduction of ColPack's dynamic orders#229
Merged
amontoison merged 2 commits intomainfrom Apr 3, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1723 1758 +35
=========================================
+ Hits 1723 1758 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amontoison
approved these changes
Apr 3, 2025
Collaborator
|
@gdalle I think you remove the following warning now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Judging by my benchmarks, this is so slow that I'm not even sure we should allow it. Switching from the naive buckets to the smart buckets means that imitating ColPack behavior has become very very expensive.