Skip to content

Store the hub(s) as tuple in star coloring#227

Closed
amontoison wants to merge 1 commit intomainfrom
hubs
Closed

Store the hub(s) as tuple in star coloring#227
amontoison wants to merge 1 commit intomainfrom
hubs

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Apr 2, 2025

close #225

@amontoison amontoison requested a review from gdalle April 2, 2025 19:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2ab1c47) to head (e03c509).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1720      1711    -9     
=========================================
- Hits          1720      1711    -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle added the benchmark Run benchmarks on PR label Apr 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2025

Benchmark Results

main e03c509... main/e03c5092cb93c7...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 1.92 ± 0.02 ms 1.87 ± 0.024 ms 1.02
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 4.38 ± 0.037 ms 4.54 ± 0.051 ms 0.965
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 9.93 ± 0.15 ms 10.9 ± 0.16 ms 0.91
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 2.55 ± 0.053 s 2.89 ± 0.043 s 0.882
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.313 ± 0.01 s 0.329 ± 0.011 s 0.95
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 1.05 ± 0.022 s 1.09 ± 0.027 s 0.962
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 6.05 ± 0.64 ms 6.02 ± 1.1 ms 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 14.2 ± 0.87 ms 14.1 ± 1.5 ms 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 31.3 ± 0.57 ms 31.3 ± 0.66 ms 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 7.51 s 7.35 s 1.02
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 1.04 ± 0.11 s 1.02 ± 0.047 s 1.02
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 3.22 ± 0.12 s 3.2 ± 0.13 s 1.01
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.49 ± 0.011 ms 0.495 ± 0.011 ms 0.99
coloring/nonsymmetric/column/direct/n=1000/p=0.005 1.23 ± 0.023 ms 1.23 ± 0.025 ms 0.996
coloring/nonsymmetric/column/direct/n=1000/p=0.01 3.1 ± 0.037 ms 3.04 ± 0.035 ms 1.02
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.603 ± 0.021 s 0.571 ± 0.0079 s 1.06
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.082 ± 0.0013 s 0.0828 ± 0.0016 s 0.99
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.218 ± 0.0088 s 0.217 ± 0.013 s 1
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.483 ± 0.011 ms 0.485 ± 0.012 ms 0.995
coloring/nonsymmetric/row/direct/n=1000/p=0.005 1.22 ± 0.019 ms 1.2 ± 0.02 ms 1.01
coloring/nonsymmetric/row/direct/n=1000/p=0.01 3.03 ± 0.034 ms 3.01 ± 0.043 ms 1.01
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.579 ± 0.017 s 0.564 ± 0.0079 s 1.03
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.0823 ± 0.00095 s 0.0795 ± 0.00094 s 1.04
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.22 ± 0.0079 s 0.205 ± 0.014 s 1.07
coloring/symmetric/column/direct/n=1000/p=0.002 1.02 ± 0.018 ms 0.976 ± 0.013 ms 1.05
coloring/symmetric/column/direct/n=1000/p=0.005 2.27 ± 0.032 ms 2.31 ± 0.038 ms 0.984
coloring/symmetric/column/direct/n=1000/p=0.01 4.92 ± 0.067 ms 5.33 ± 0.043 ms 0.922
coloring/symmetric/column/direct/n=100000/p=0.0001 0.89 ± 0.024 s 1.02 ± 0.005 s 0.869
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.147 ± 0.0015 s 0.145 ± 0.0024 s 1.01
coloring/symmetric/column/direct/n=100000/p=5.0e-5 0.358 ± 0.0092 s 0.394 ± 0.013 s 0.908
coloring/symmetric/column/substitution/n=1000/p=0.002 3.17 ± 0.19 ms 3.16 ± 0.098 ms 1
coloring/symmetric/column/substitution/n=1000/p=0.005 7.21 ± 0.12 ms 7.2 ± 0.093 ms 1
coloring/symmetric/column/substitution/n=1000/p=0.01 15.6 ± 0.17 ms 15.7 ± 0.2 ms 0.997
coloring/symmetric/column/substitution/n=100000/p=0.0001 3.29 ± 0.023 s 3.22 ± 0.02 s 1.02
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 0.467 ± 0.042 s 0.47 ± 0.041 s 0.994
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 1.26 ± 0.067 s 1.34 ± 0.085 s 0.944
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.142 ± 0.0059 ms 0.154 ± 0.006 ms 0.925
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.23 ± 0.0087 ms 0.233 ± 0.0087 ms 0.987
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.373 ± 0.013 ms 0.382 ± 0.014 ms 0.978
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.098 ± 0.0062 s 0.0991 ± 0.0078 s 0.989
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.0337 ± 0.0016 s 0.0334 ± 0.0019 s 1.01
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.0596 ± 0.0032 s 0.0598 ± 0.0048 s 0.996
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.155 ± 0.0067 ms 0.158 ± 0.0075 ms 0.981
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.309 ± 0.012 ms 0.309 ± 0.011 ms 0.999
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.614 ± 0.017 ms 0.603 ± 0.016 ms 1.02
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.219 ± 0.011 s 0.217 ± 0.02 s 1.01
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.0424 ± 0.0024 s 0.043 ± 0.0024 s 0.987
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.097 ± 0.0049 s 0.0964 ± 0.0058 s 1.01
decompress/nonsymmetric/column/direct/n=1000/p=0.002 25.9 ± 2 μs 25.2 ± 1.8 μs 1.03
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.0485 ± 0.0039 ms 0.0478 ± 0.0026 ms 1.02
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.0864 ± 0.0056 ms 0.0879 ± 0.0061 ms 0.982
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 27.1 ± 2.7 ms 26.3 ± 2.4 ms 1.03
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 4.75 ± 0.46 ms 4.67 ± 0.45 ms 1.02
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 12 ± 0.98 ms 12.4 ± 1.4 ms 0.966
decompress/nonsymmetric/row/direct/n=1000/p=0.002 24.6 ± 1.7 μs 24.6 ± 1.8 μs 1
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.0429 ± 0.0035 ms 0.0424 ± 0.0027 ms 1.01
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.0761 ± 0.0055 ms 0.0767 ± 0.0056 ms 0.992
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 12 ± 1.6 ms 12.4 ± 1.6 ms 0.974
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 3.21 ± 0.22 ms 3.17 ± 0.33 ms 1.01
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 6.27 ± 0.5 ms 5.92 ± 0.56 ms 1.06
decompress/symmetric/column/direct/n=1000/p=0.002 25.7 ± 2.5 μs 25.6 ± 1.7 μs 1.01
decompress/symmetric/column/direct/n=1000/p=0.005 0.0454 ± 0.0024 ms 0.0472 ± 0.0024 ms 0.962
decompress/symmetric/column/direct/n=1000/p=0.01 0.0826 ± 0.0057 ms 0.0854 ± 0.0052 ms 0.967
decompress/symmetric/column/direct/n=100000/p=0.0001 22.8 ± 2.1 ms 25.4 ± 3.3 ms 0.898
decompress/symmetric/column/direct/n=100000/p=2.0e-5 4.33 ± 0.49 ms 4.77 ± 0.54 ms 0.908
decompress/symmetric/column/direct/n=100000/p=5.0e-5 11.2 ± 1 ms 12.1 ± 0.98 ms 0.929
decompress/symmetric/column/substitution/n=1000/p=0.002 0.104 ± 0.0043 ms 0.104 ± 0.0038 ms 1
decompress/symmetric/column/substitution/n=1000/p=0.005 0.182 ± 0.0083 ms 0.194 ± 0.0094 ms 0.939
decompress/symmetric/column/substitution/n=1000/p=0.01 0.355 ± 0.013 ms 0.357 ± 0.014 ms 0.996
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.102 ± 0.0055 s 0.104 ± 0.0036 s 0.985
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 24.1 ± 1.1 ms 24.2 ± 1.1 ms 0.996
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.0492 ± 0.0017 s 0.0496 ± 0.0015 s 0.993
time_to_load 0.219 ± 0.0026 s 0.222 ± 0.0033 s 0.986
main e03c509... main/e03c5092cb93c7...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.475 k allocs: 2.35 MB 0.48 k allocs: 2.45 MB 0.957
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.485 k allocs: 3.96 MB 0.49 k allocs: 4.22 MB 0.938
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.495 k allocs: 6.99 MB 0.5 k allocs: 7.58 MB 0.922
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.555 k allocs: 0.712 GB 0.56 k allocs: 0.797 GB 0.893
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.525 k allocs: 0.24 GB 0.53 k allocs: 0.249 GB 0.964
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.545 k allocs: 0.426 GB 0.55 k allocs: 0.467 GB 0.912
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.0512 M allocs: 6.36 MB 0.0512 M allocs: 6.36 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.0978 M allocs: 11.4 MB 0.0978 M allocs: 11.4 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.187 M allocs: 21.8 MB 0.187 M allocs: 21.8 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 17.9 M allocs: 2.03 GB 17.9 M allocs: 2.03 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 4.93 M allocs: 0.585 GB 4.93 M allocs: 0.585 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 9.54 M allocs: 1.13 GB 9.54 M allocs: 1.13 GB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/symmetric/column/direct/n=1000/p=0.002 0.22 k allocs: 0.583 MB 0.225 k allocs: 0.619 MB 0.943
coloring/symmetric/column/direct/n=1000/p=0.005 0.23 k allocs: 0.932 MB 0.235 k allocs: 1.04 MB 0.899
coloring/symmetric/column/direct/n=1000/p=0.01 0.24 k allocs: 1.57 MB 0.245 k allocs: 1.83 MB 0.858
coloring/symmetric/column/direct/n=100000/p=0.0001 0.3 k allocs: 0.168 GB 0.305 k allocs: 0.209 GB 0.803
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.27 k allocs: 0.056 GB 0.275 k allocs: 0.0599 GB 0.935
coloring/symmetric/column/direct/n=100000/p=5.0e-5 0.29 k allocs: 0.0995 GB 0.295 k allocs: 0.119 GB 0.836
coloring/symmetric/column/substitution/n=1000/p=0.002 25.5 k allocs: 2.68 MB 25.5 k allocs: 2.68 MB 1
coloring/symmetric/column/substitution/n=1000/p=0.005 0.0492 M allocs: 4.95 MB 0.0492 M allocs: 4.95 MB 1
coloring/symmetric/column/substitution/n=1000/p=0.01 0.0937 M allocs: 9.72 MB 0.0937 M allocs: 9.72 MB 1
coloring/symmetric/column/substitution/n=100000/p=0.0001 8.95 M allocs: 0.887 GB 8.95 M allocs: 0.887 GB 1
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 2.47 M allocs: 0.246 GB 2.47 M allocs: 0.246 GB 1
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 4.77 M allocs: 0.49 GB 4.77 M allocs: 0.49 GB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@amontoison amontoison closed this Apr 2, 2025
@amontoison
Copy link
Copy Markdown
Collaborator Author

amontoison commented Apr 2, 2025

It is faster without this modification.

@amontoison amontoison deleted the hubs branch April 2, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gdalle gdalle Awaiting requested review from gdalle

Assignees

No one assigned

Labels

benchmark Run benchmarks on PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Store hubs as tuples

2 participants

@amontoison @gdalle