Skip to content

Improve degree and nb_edges#211

Closed
amontoison wants to merge 2 commits intomainfrom
optimized_nb_edges
Closed

Improve degree and nb_edges#211
amontoison wants to merge 2 commits intomainfrom
optimized_nb_edges

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Mar 25, 2025

  • Specialize degreeand nb_edges if we have loops or not.
  • Don't check all values in degree if it's not needed.

@amontoison amontoison requested a review from gdalle March 25, 2025 19:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.75%. Comparing base (848a6f3) to head (3a39e63).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/graph.jl 73.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #211      +/-   ##
===========================================
- Coverage   100.00%   99.75%   -0.25%     
===========================================
  Files           14       14              
  Lines         1638     1647       +9     
===========================================
+ Hits          1638     1643       +5     
- Misses           0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing coverage because our default test suite for bicoloring only uses the random order, which never computes degrees.
We might want to test in the random suite with LargestFirst() too?

@amontoison
Copy link
Copy Markdown
Collaborator Author

Yes, good idea!

@amontoison
Copy link
Copy Markdown
Collaborator Author

Simplified and added in #214

@amontoison amontoison closed this Apr 1, 2025
@amontoison amontoison deleted the optimized_nb_edges branch April 1, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants