Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
===========================================
- Coverage 100.00% 99.75% -0.25%
===========================================
Files 14 14
Lines 1638 1647 +9
===========================================
+ Hits 1638 1643 +5
- Misses 0 4 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdalle
requested changes
Mar 31, 2025
Member
gdalle
left a comment
There was a problem hiding this comment.
I think we're missing coverage because our default test suite for bicoloring only uses the random order, which never computes degrees.
We might want to test in the random suite with LargestFirst() too?
Collaborator
Author
|
Yes, good idea! |
Collaborator
Author
|
Simplified and added in #214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
degreeandnb_edgesif we have loops or not.degreeif it's not needed.