Skip to content

Remove some dictionaries in star and acyclic coloring#207

Closed
amontoison wants to merge 3 commits intomainfrom
star_coloring_without_dict
Closed

Remove some dictionaries in star and acyclic coloring#207
amontoison wants to merge 3 commits intomainfrom
star_coloring_without_dict

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Mar 25, 2025

Quick test to see how much we gain with a dictionary.
Finding the index of an edge before this PR was O(1), now it is O(log(n)).
It can also be `O(1) without a dictionary but it requires more modifications and I would like to know what is the gap already.

@amontoison amontoison changed the title Star coloring without dictionaries Star coloring without a dictionary Mar 25, 2025
@amontoison amontoison force-pushed the star_coloring_without_dict branch from d9cdea8 to 0f7a9b1 Compare March 25, 2025 06:37
@amontoison amontoison added the benchmark Run benchmarks on PR label Mar 25, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a113eea) to head (0f7a9b1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1647      1666   +19     
=========================================
+ Hits          1647      1666   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amontoison amontoison closed this Mar 25, 2025
@amontoison amontoison reopened this Mar 25, 2025
@amontoison amontoison force-pushed the star_coloring_without_dict branch from 0f7a9b1 to b1c86db Compare March 25, 2025 14:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2025

Benchmark Results

main 9d5d09f... main/9d5d09fde41ec8...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 2.98 ± 0.18 ms 2.75 ± 0.18 ms 1.09
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 7.93 ± 0.37 ms 7.56 ± 0.39 ms 1.05
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 19.7 ± 0.34 ms 19.8 ± 0.32 ms 0.993
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 5.85 s 4.87 ± 0.04 s 1.2
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.534 ± 0.047 s 0.468 ± 0.016 s 1.14
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 1.83 ± 0.023 s 1.53 ± 0.024 s 1.2
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 7.26 ± 0.12 ms 6.55 ± 0.084 ms 1.11
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 17.7 ± 0.19 ms 16.1 ± 0.15 ms 1.1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.0394 ± 0.00037 s 0.0366 ± 0.0004 s 1.08
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 9.18 s 7.9 s 1.16
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 1.24 ± 0.11 s 0.979 ± 0.044 s 1.26
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 3.83 ± 0.12 s 3.14 ± 0.056 s 1.22
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.493 ± 0.015 ms 0.496 ± 0.019 ms 0.992
coloring/nonsymmetric/column/direct/n=1000/p=0.005 1.22 ± 0.2 ms 1.23 ± 0.21 ms 0.995
coloring/nonsymmetric/column/direct/n=1000/p=0.01 3.07 ± 0.025 ms 3.03 ± 0.33 ms 1.01
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.545 ± 0.016 s 0.528 ± 0.011 s 1.03
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.0823 ± 0.012 s 0.0814 ± 0.013 s 1.01
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.215 ± 0.01 s 0.211 ± 0.011 s 1.02
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.482 ± 0.014 ms 0.483 ± 0.02 ms 0.998
coloring/nonsymmetric/row/direct/n=1000/p=0.005 1.21 ± 0.2 ms 1.21 ± 0.21 ms 0.999
coloring/nonsymmetric/row/direct/n=1000/p=0.01 3.06 ± 0.028 ms 3.06 ± 0.32 ms 0.999
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.552 ± 0.015 s 0.53 ± 0.018 s 1.04
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.0828 ± 0.012 s 0.0816 ± 0.013 s 1.01
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.21 ± 0.01 s 0.214 ± 0.01 s 0.98
coloring/symmetric/column/direct/n=1000/p=0.002 1.55 ± 0.026 ms 1.53 ± 0.022 ms 1.01
coloring/symmetric/column/direct/n=1000/p=0.005 4 ± 0.039 ms 4.04 ± 0.037 ms 0.991
coloring/symmetric/column/direct/n=1000/p=0.01 9.77 ± 0.075 ms 10.4 ± 0.068 ms 0.941
coloring/symmetric/column/direct/n=100000/p=0.0001 2.26 ± 0.048 s 1.95 ± 0.015 s 1.16
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.222 ± 0.0086 s 0.223 ± 0.0095 s 0.994
coloring/symmetric/column/direct/n=100000/p=5.0e-5 0.704 ± 0.02 s 0.667 ± 0.016 s 1.06
coloring/symmetric/column/substitution/n=1000/p=0.002 3.63 ± 0.073 ms 3.33 ± 0.045 ms 1.09
coloring/symmetric/column/substitution/n=1000/p=0.005 8.74 ± 0.076 ms 8.04 ± 0.072 ms 1.09
coloring/symmetric/column/substitution/n=1000/p=0.01 19.6 ± 0.13 ms 18.3 ± 0.13 ms 1.07
coloring/symmetric/column/substitution/n=100000/p=0.0001 3.91 ± 0.044 s 3.34 ± 0.007 s 1.17
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 0.523 ± 0.023 s 0.449 ± 0.022 s 1.17
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 1.49 ± 0.055 s 1.31 ± 0.076 s 1.14
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.143 ± 0.0074 ms 0.148 ± 0.0056 ms 0.965
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.232 ± 0.0088 ms 0.236 ± 0.0088 ms 0.983
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.386 ± 0.011 ms 0.389 ± 0.012 ms 0.993
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.0885 ± 0.0045 s 0.0885 ± 0.0037 s 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 30.3 ± 2.1 ms 29.7 ± 1.1 ms 1.02
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.0556 ± 0.001 s 0.0564 ± 0.0014 s 0.986
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.16 ± 0.0076 ms 0.159 ± 0.0079 ms 1.01
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.314 ± 0.01 ms 0.313 ± 0.01 ms 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.612 ± 0.013 ms 0.61 ± 0.014 ms 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.203 ± 0.0096 s 0.195 ± 0.011 s 1.04
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.0399 ± 0.0026 s 0.0379 ± 0.0023 s 1.05
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.0857 ± 0.0084 s 0.0876 ± 0.0059 s 0.979
decompress/nonsymmetric/column/direct/n=1000/p=0.002 26.3 ± 1.2 μs 26.2 ± 1.3 μs 1
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.0487 ± 0.0017 ms 0.0493 ± 0.0018 ms 0.989
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.0901 ± 0.0035 ms 0.0907 ± 0.0055 ms 0.994
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 24.4 ± 0.91 ms 25.6 ± 1.6 ms 0.954
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 4.2 ± 0.28 ms 4.48 ± 0.37 ms 0.938
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 11.3 ± 0.29 ms 12.1 ± 0.35 ms 0.936
decompress/nonsymmetric/row/direct/n=1000/p=0.002 25 ± 1.3 μs 24.8 ± 1.2 μs 1.01
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.0456 ± 0.0021 ms 0.0435 ± 0.0014 ms 1.05
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.0742 ± 0.0032 ms 0.0794 ± 0.0032 ms 0.936
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 11.5 ± 0.44 ms 11.7 ± 0.51 ms 0.985
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 3.11 ± 0.11 ms 3.05 ± 0.11 ms 1.02
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 5.83 ± 0.2 ms 5.96 ± 0.21 ms 0.978
decompress/symmetric/column/direct/n=1000/p=0.002 25.4 ± 2 μs 24.7 ± 71 μs 1.03
decompress/symmetric/column/direct/n=1000/p=0.005 0.0458 ± 0.0019 ms 0.0456 ± 0.0017 ms 1
decompress/symmetric/column/direct/n=1000/p=0.01 0.082 ± 0.0038 ms 0.0814 ± 0.0046 ms 1.01
decompress/symmetric/column/direct/n=100000/p=0.0001 20.5 ± 1 ms 20.6 ± 0.94 ms 0.995
decompress/symmetric/column/direct/n=100000/p=2.0e-5 3.61 ± 0.41 ms 3.58 ± 0.46 ms 1.01
decompress/symmetric/column/direct/n=100000/p=5.0e-5 10.2 ± 0.29 ms 10.1 ± 0.36 ms 1.01
decompress/symmetric/column/substitution/n=1000/p=0.002 0.107 ± 0.0029 ms 0.103 ± 0.0028 ms 1.03
decompress/symmetric/column/substitution/n=1000/p=0.005 0.174 ± 0.0076 ms 0.171 ± 0.0073 ms 1.02
decompress/symmetric/column/substitution/n=1000/p=0.01 0.336 ± 0.011 ms 0.358 ± 0.012 ms 0.94
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.0925 ± 0.0038 s 0.0891 ± 0.0043 s 1.04
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 25.8 ± 0.46 ms 23.1 ± 0.43 ms 1.12
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.0493 ± 0.00088 s 0.047 ± 0.0013 s 1.05
time_to_load 0.238 ± 0.0012 s 0.238 ± 0.0019 s 1
main 9d5d09f... main/9d5d09fde41ec8...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 12.7 k allocs: 3.1 MB 12.8 k allocs: 2.93 MB 1.06
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 29.4 k allocs: 5.67 MB 29.5 k allocs: 5.34 MB 1.06
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.0612 M allocs: 10.6 MB 0.0613 M allocs: 9.9 MB 1.07
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 6.05 M allocs: 1.15 GB 6.05 M allocs: 1.02 GB 1.12
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 1.18 M allocs: 0.324 GB 1.18 M allocs: 0.293 GB 1.11
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 2.87 M allocs: 0.635 GB 2.87 M allocs: 0.576 GB 1.1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.0513 M allocs: 6.61 MB 0.0513 M allocs: 6.43 MB 1.03
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.0978 M allocs: 12 MB 0.0979 M allocs: 11.5 MB 1.04
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.187 M allocs: 22.8 MB 0.187 M allocs: 21.9 MB 1.04
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 17.9 M allocs: 2.2 GB 17.9 M allocs: 2.03 GB 1.08
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 4.93 M allocs: 0.623 GB 4.93 M allocs: 0.585 GB 1.07
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 9.54 M allocs: 1.21 GB 9.54 M allocs: 1.13 GB 1.07
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/symmetric/column/direct/n=1000/p=0.002 6.26 k allocs: 0.902 MB 6.33 k allocs: 0.818 MB 1.1
coloring/symmetric/column/direct/n=1000/p=0.005 14.5 k allocs: 1.72 MB 14.6 k allocs: 1.56 MB 1.1
coloring/symmetric/column/direct/n=1000/p=0.01 30.6 k allocs: 3.32 MB 30.7 k allocs: 2.96 MB 1.12
coloring/symmetric/column/direct/n=100000/p=0.0001 3.02 M allocs: 0.38 GB 3.02 M allocs: 0.318 GB 1.2
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.589 M allocs: 0.0939 GB 0.589 M allocs: 0.0783 GB 1.2
coloring/symmetric/column/direct/n=100000/p=5.0e-5 1.44 M allocs: 0.199 GB 1.44 M allocs: 0.17 GB 1.17
coloring/symmetric/column/substitution/n=1000/p=0.002 25.6 k allocs: 2.84 MB 25.6 k allocs: 2.61 MB 1.09
coloring/symmetric/column/substitution/n=1000/p=0.005 0.0492 M allocs: 5.17 MB 0.0492 M allocs: 4.91 MB 1.05
coloring/symmetric/column/substitution/n=1000/p=0.01 0.0937 M allocs: 10.3 MB 0.0937 M allocs: 9.53 MB 1.08
coloring/symmetric/column/substitution/n=100000/p=0.0001 8.95 M allocs: 0.965 GB 8.95 M allocs: 0.884 GB 1.09
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 2.47 M allocs: 0.262 GB 2.47 M allocs: 0.242 GB 1.08
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 4.77 M allocs: 0.525 GB 4.77 M allocs: 0.486 GB 1.08
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@amontoison amontoison force-pushed the star_coloring_without_dict branch from 3e1c220 to 87178db Compare March 25, 2025 20:37
@amontoison amontoison changed the title Star coloring without a dictionary Remove some dictionaries in star and acyclic coloring Mar 25, 2025
@amontoison amontoison force-pushed the star_coloring_without_dict branch from 87178db to 5d994a1 Compare March 25, 2025 20:44
@amontoison amontoison force-pushed the star_coloring_without_dict branch from 5d994a1 to 9d5d09f Compare March 26, 2025 01:01
@gdalle gdalle marked this pull request as draft March 26, 2025 07:14
@gdalle
Copy link
Copy Markdown
Member

gdalle commented Mar 26, 2025

Putting this on hold while we think of an integer-based approach to edge identification

@amontoison
Copy link
Copy Markdown
Collaborator Author

amontoison commented Mar 28, 2025

Not relevant anymore since we found how to avoid the use of a sparse strict upper triangular matrix / dictionary to do the mapping between edges and their index.

@amontoison amontoison closed this Mar 28, 2025
@gdalle gdalle deleted the star_coloring_without_dict branch March 28, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Run benchmarks on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants