Remove some dictionaries in star and acyclic coloring#207
Closed
amontoison wants to merge 3 commits intomainfrom
Closed
Remove some dictionaries in star and acyclic coloring#207amontoison wants to merge 3 commits intomainfrom
amontoison wants to merge 3 commits intomainfrom
Conversation
d9cdea8 to
0f7a9b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1647 1666 +19
=========================================
+ Hits 1647 1666 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0f7a9b1 to
b1c86db
Compare
Contributor
Benchmark Results
|
3e1c220 to
87178db
Compare
87178db to
5d994a1
Compare
5d994a1 to
9d5d09f
Compare
Member
|
Putting this on hold while we think of an integer-based approach to edge identification |
Collaborator
Author
|
Not relevant anymore since we found how to avoid the use of a sparse strict upper triangular matrix / dictionary to do the mapping between edges and their index. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick test to see how much we gain with a dictionary.
Finding the index of an edge before this PR was
O(1), now it isO(log(n)).It can also be `O(1) without a dictionary but it requires more modifications and I would like to know what is the gap already.