Fix Constructor derive emitting redundant_field_names lint - #560
Open
akundaz wants to merge 1 commit into
Open
Conversation
Author
|
The CI failure ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Constructorderive for named-field structs was generating:instead of the field init shorthand:
This triggers
clippy::redundant_field_nameson nightly Clippy when-D warningsis set, breaking crates that use#[deny(clippy::all)]or similar.Fix: use
#(#field_names),*in the struct literal rather than#(#field_names: #vars),*. Since the parameter names already match the field names, the shorthand is always valid here. This also removes a redundant variable alias and clone instruct_body.