Repository navigation
test: no API test can open the real ~/.claude_karma/metadata.db (#124 part 1) - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Five tests in
tests/api/test_set_session_title.pyopen the real~/.claude_karma/metadata.dbthrough the title cache, andtest_set_title_successrunsensure_schemaon it viaget_writer_db(). A contributor running the suite on a schema-changing branch migrates their own live DB without noticing (part 1 of #124). #123 isolatedclaude_basebut notkarma_base, which is where the DB path comes from.Changes
tests/api/conftest.py: a second autouse fixture redirectsSettings.karma_baseto a per-test temp dir, which covers both the title cache andsqlite_db_path, and resets the writer singleton before and after each test. Test code only.Verification
A
sqlite3.connectspy over the fullapisuite, recording every path under~/.claude_karma:test_set_session_titletests)Full suite without the spy: 1977 passed, 6 skipped in 8.4 s.
ruff check tests/andruff format --checkclean.Follow-ups
Part 2 of #124 (
spawned_atNOT NULL failure in the shells extractor on real JSONL) stays open.