Repository navigation
ci: fix the 3.9 desktop-launcher leg and the guard job's dependency set - #120
Merged
Merged
Conversation
…'s requirements in the guard job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Desktop Launcher workflow has two failures that are ours, not the contributors'.
ubuntu-latestnow resolves to Ubuntu 26.04, which has no Python 3.9 in the toolcache, so the 3.9 leg fails on every run (seen on #109, #110, #115, #116 today; main's next push hits it too). The "API guard tests + lint" job installs a hand-picked pip list instead of the API's requirements, so any change that makesrouters.desktop_appimport a module that pullscachetoolsfails there (#115 does).Changes
ubuntu-24.04, so it keeps enforcing the oldest supported interpreter.-r api/requirements.txtplus ruff and pytest, so it tests against the API's real dependency set.Verification
CI on this PR. Error text from the failing runs:
The version '3.9' with architecture 'x64' was not found for Ubuntu 26.04(run 39116249530) andModuleNotFoundError: No module named 'cachetools'(same run, guard job).Follow-ups
None.