Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ futures = "0.3.32"
hyperrat = { path = "crates/hyperrat", version = "0.1.3" }
inquire = "0.9.4"
keyring = { version = "3.6.3", features = ["apple-native", "windows-native"] }
octocrab = "0.49.7"
octocrab = "0.53.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Rust Version Requirement Can Break Builds

octocrab 0.53.1 uses newer standard-library APIs than the previous version. This crate does not declare a rust-version, so builds that still use an older Rust toolchain can start failing at dependency compile time after this bump instead of getting a clear resolver error.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Pull Request Model Shape May Drift

octocrab 0.52 changed the pull request response model, and this codebase reads issue.pull_request.html_url from issue payloads in the UI conversion path. If the new model maps issue pull request data to a simpler shape without that field, this dependency bump can break compilation or leave pull request issue previews without their link.

pulldown-cmark = "0.13.3"
regex = "1.11.1"
rat-cursor = "2.0.0"
Expand Down
Loading