Added Fasm as a submodule to allow for easiar debugging/development.#2
Open
pauldotknopf wants to merge 1 commit into
Open
Added Fasm as a submodule to allow for easiar debugging/development.#2pauldotknopf wants to merge 1 commit into
pauldotknopf wants to merge 1 commit into
Conversation
Contributor
|
Yep submodules rule! |
Contributor
|
Actually it might be better to use a subtree. |
Owner
|
Hey @CoolOppo and @pauldotknopf! Sorry for the long delay! This is a good idea! I read some articles about subtree vs submodules... I have the feeling a subtree would be overkill for Fasm.NET compared to a submodule. What do you think guys ? Isn't a submodule sufficient for this library ? Cheers |
Contributor
|
Yeah now that I have more experience with Git, I'd day a submodule is absolutely fine. You just have to be very careful to always commit and push any changes in order not to break the main repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.