Fix thinking detection for ChatGPT's current Stop control

[JJLiebig]

ChatGPT's icon-only Stop control was recognized by submission and answer capture but missed by the thinking monitor, which repeatedly reported no thinking status during a successful Pro run.

Reuse the shared Stop selector in the monitor, require the control to be visible, and preserve the passive Answer now gate. Add regression coverage for both Stop selectors, hidden controls, and the current Pro gate. Update the changelog and Windows notes.

Validation: four focused detector tests, build, lint/typecheck, formatting, package dry run, and Review Suite fast passed at 1faf2c7 (rvw_1387c974; both reviewers had no findings). PR CI 38609480081 passed the full suite with default timeouts on Linux, macOS, and Windows. CodeRabbit reported no actionable findings; its docstring warning skipped both analyzed functions as unsupported. The local default full suite passed 349/352 tests with three profile-migration timeouts; an isolated rerun passed 17/18 with one timeout. No test deadlines or migration code were changed. No live ChatGPT smoke was run. The documented plugin-validator script is missing locally; plugin metadata and skill files are unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 96b1ae3b-4890-4821-85fd-7ffbf3242bfd

📥 Commits

Reviewing files that changed from the base of the PR and between 0c35b04 and 1faf2c7.

📒 Files selected for processing: 4

• CHANGELOG.md
• docs/windows-work.md
• src/browser/actions/thinkingStatus.ts
• tests/browser/thinkingStatus.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Thinking-status monitoring now recognizes visible composer Stop controls as activity. Tests cover both supported Stop selectors, hidden controls, and the Pro-gate case. The changelog and Windows notes describe the updated detection.

Changes: Thinking status detection

Layer / File(s)	Summary
Detect visible composer Stop controls src/browser/actions/thinkingStatus.ts, tests/browser/thinkingStatus.test.ts, docs/windows-work.md, CHANGELOG.md	The status check recognizes visible controls matching STOP_BUTTON_SELECTOR. Tests cover aria-label="Stop", data-testid="stop-button", hidden controls, and the Pro-gate case. They also verify that the monitor does not click Stop or Answer now. The Windows notes and changelog describe the detection.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 1faf2

The Stop-control detection is ready to merge after normal checks; no actionable issue remains.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: fixing thinking detection for ChatGPT's current Stop control.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}