Skip to content

Add optional GitHub connection checks and resumable onboarding - #28

Merged
JJLiebig merged 4 commits into
mainfrom
feat/github-connected-context
Oct 9, 2026
Merged

JJLiebig merged 4 commits into
mainfrom
feat/github-connected-context

Conversation

@JJLiebig

@JJLiebig JJLiebig commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

ask-pro --github now checks the signed-in ChatGPT account's GitHub connection before uploading the context bundle or sending the prompt. If setup is needed or the UI cannot confirm a connection, it opens the GitHub plugin page and returns a resumable handoff. After the human connects the account, --resume checks again and submits the original request; ordinary consults do not require GitHub.

The option persists with the session, defaults to normal ChatGPT, and asks Pro for read-only repository evidence with citations and revision information. The maintained skill prefers GitHub for committed code and reserves source-file bundles for local changes or evidence the app cannot retrieve. The current ChatGPT GitHub plugin advertises write capabilities: this is not an enforced read-only permission mode. ask-pro does not collect GitHub credentials, automate consent, select repositories, approve app actions, or prove repository access from connection status alone.

Validation:

  • Connection-state checks cover connected, disconnected, expired, hidden, unrelated, and unavailable UI states without consent or credential access.
  • Runner tests cover login/setup handoff, repeated resume before connection, and fresh submission instead of harvesting an unsent conversation.
  • Full local suite passed: 335 tests across 20 files. The subsequent recovery fixes passed all 99 owning browser/runner tests. Build, lint, format, plugin/skill validators, package dry-run, and isolated plugin refresh/runner smoke passed.
  • Review Suite fast rvw_e3036c1d completed with both reviewers clean at 6bb682e.
  • Live trial in the existing ask-pro profile paused with NEEDS_GITHUB_CONNECTION before submission. After human setup, resume passed the connection check, selected Pro, and returned independently verified facts from the requested profilePaths.ts commit, with no source files uploaded. The answer reports GitHub file retrieval and the requested revision, but the harvested citation link was absent and the activity panel was not independently inspected. This proves handoff/resume and answer accuracy; it does not independently prove the tool trace or a disconnected initial account. Final recovery-only fixes were covered by tests/CI after the live run started.
  • Windows/macOS/Linux CI passed on final head b9506ed. Publication was skipped for the PR. The only change after clean review was the manual-test evidence note.

No dependencies added. README, maintained skill, Windows notes, changelog, and manual smoke steps cover the new flow and permission limits.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 93ce0038-b60d-4c57-939b-0872c5aa04a3

📥 Commits

Reviewing files that changed from the base of the PR and between a673c37 and b9506ed.


📒 Files selected for processing (15)
  • AGENTS.md
  • CHANGELOG.md
  • README.md
  • bin/ask-pro-cli.ts
  • docs/manual-tests.md
  • docs/windows-work.md
  • skills/ask-pro/SKILL.md
  • src/ask-pro/browserRunner.ts
  • src/ask-pro/session.ts
  • src/browser/actions/github.ts
  • src/browser/index.ts
  • src/browser/types.ts
  • tests/ask-pro/browserRunner.test.ts
  • tests/ask-pro/cli.test.ts
  • tests/browser/github.test.ts

 __________________________________________________________________________________________________________________________________
< Functions delay binding; data structures induce binding. Moral: Structure data late in the programming process. - Alan J. Perlis >
 ----------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JJLiebig JJLiebig changed the title docs: add optional GitHub context workflow Add optional GitHub connection checks and resumable onboarding Oct 9, 2026
@JJLiebig
JJLiebig marked this pull request as ready for review October 9, 2026 23:07
@JJLiebig
JJLiebig merged commit ab1fe4d into main Oct 9, 2026
5 checks passed
@JJLiebig
JJLiebig deleted the feat/github-connected-context branch October 9, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant