Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The output stream was rounding results when writing to the csv file, causing differences between R and the output stream results.
This comment was marked as outdated.
This comment was marked as outdated.
Use an explicit csv parser when reading in the input table header
This comment was marked as outdated.
This comment was marked as outdated.
* Increase the initial earth pool c size for idealized runs * Remove the unused initial atmos co2 c pool definition from the ini files
Remove the current implementation of the NBP constraint.
* Update the halocarbon parameter values and fix the units used internally to calculate the emissions-to-concentration conversion factor. * Resolve the ambiguity between the unadjusted vs adjusted RF * Add missing CH3CCl3 concentration constraint to the example input files and fix the typo in the HFC245fa concentration constraint column missing * Add the following helper functions: ALL_HALOCARBON_CONCENTRATIONS(), ALL_HALOCARBON_CONSTRAINTS(), ALL_HALOCARBON_EMISSIONS(), ALL_HALOCARBON_RF() to return the strings for all the halocarbon related hector variables
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 80.39% 80.25% -0.15%
==========================================
Files 61 61
Lines 6025 5941 -84
==========================================
- Hits 4844 4768 -76
+ Misses 1181 1173 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hector V3.5.5 Release PR
This PR documents the various bug fixes and relatively minor model development included in the V3.5.5 release. While there have been some changes to the structure of the ini files that will cause incompatibility with older ini files much of the hector structure and behavior remains the same, hence only the minor semantic version upgrade.