Updates from GMAO macOS Testing - #92
Merged
Merged
Conversation
climbfuji
approved these changes
Sep 29, 2026
climbfuji
left a comment
climbfuji
left a comment
Collaborator
There was a problem hiding this comment.
I don't have a way to test this. The changes affect macOS + (LLVM or NAG) only.
This was referenced Sep 29, 2026
Collaborator
Author
Well, I guess the FMS LLVM patch affects anyone building FMS 2026.01.01 with Flang. I do have a PR in with FMS upstream but I guess that'll be in 2026.03 or something? |
Collaborator
Author
|
And oh. we need two reviewers. I guess I nominate @AlexanderRichert-NOAA :) |
5 of 10 tasks
Collaborator
|
@AlexanderRichert-NOAA Can you approve this dependency as well, please? |
Collaborator
|
I'll proceed based on the approval of the parent PR for spack-stack JCSDA/spack-stack#2136. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my testing to add HDF5 (see JCSDA/spack-stack#1822), on macOS I needed some changes.
Most come from trying to build a flang stack as it looks like flang + Darwin is a bit rare. These include package fixes to
pfunit,hdf5,openmpi, andparallelio. I have upstream spack/spack-packages PRs open for this, but as at least HDF5 and Open MPI are "big" ones, it can be slow to pull in.I also update the
llvmpackage itself as my mac now has flang 23.1.2.