Launch fewer CMake subprocesses - #356
Merged
Merged
Conversation
fmahebert
requested review from
BenjaminTJohnson,
chengdang,
climbfuji and
srherbener
August 13, 2026 19:57
climbfuji
reviewed
Aug 13, 2026
climbfuji
left a comment
climbfuji
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me, but I haven't tested it.
BenjaminTJohnson
approved these changes
Aug 17, 2026
BenjaminTJohnson
added a commit
that referenced
this pull request
Aug 25, 2026
Brings in v3.1.5 (PR #364: netCDF SpcCoeff sibling-load fix + test_NLTE_Verification) and the CMake download/untar refactors (PR #354, #356). Conflict resolution: - CMakeLists.txt, VERSION.cmake, README.md: keep the 3.2.0 version strings; add the v3.1.5 line to the README release history. - SpcCoeff_netCDF_IO.f90: keep this branch's version. develop's fix is a subset of it (same sibling load, minus the "no sibling found" INFORMATION messages). - test/CMakeLists.txt: keep the fix_REL-3.2.0.0 tarball/checksum on top of develop's combined download+untar block; keep the netCDF-only coefficient staging list and add the iasi616_metop-b SpcCoeff/NLTECoeff/TauCoeff set the new test needs; port the testinput_no_siblings staging block to the netCDF filenames since the 3.2.0 tarball ships no .bin coefficients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how symlinks are handled by CRTM, to reduce the number of CMake processes being launched and speed up CMake configuration time. See https://github.com/JCSDA-internal/jedi-bundle/issues/157.
execute_process( ... -E create_symlink )withfile( CREATE_LINK ... SYMBOLIC )Issue(s) addressed
Towards https://github.com/JCSDA-internal/jedi-bundle/issues/157
Dependencies
Impact
Checklist