Skip to content

update build process for python>=3.8 - #11

Open
mchasse wants to merge 1 commit into
Intsights:masterfrom
mchasse:update-to-abi3-py38
Open

update build process for python>=3.8#11
mchasse wants to merge 1 commit into
Intsights:masterfrom
mchasse:update-to-abi3-py38

Conversation

@mchasse

@mchasse mchasse commented Jul 25, 2026

Copy link
Copy Markdown

These changes were done with Claude Code.
Upgrade to PyO3 0.22, adblock-rust 0.8, and abi3 wheel (Path B)

  • Cargo.toml: Bump version to 0.6.0; upgrade PyO3 from 0.16.5 to 0.22; upgrade adblock from 0.5 to 0.8
  • Cargo.toml: Add transitive pin rmp = ">=0.8, <0.8.15" to guard against a semver-breaking change in rmp 0.8.15 that breaks adblock's transitive dep rmp-serde 0.15.5 — necessary because Cargo.lock is gitignored for this library
  • src/lib.rs: Replace Engine::from_rules with FilterSet::new + FilterSet::add_filters + Engine::from_filter_set, matching the adblock 0.8 API
  • src/lib.rs: Replace removed Engine::check_network_urls with check_network_request(&Request), building a Request via Request::new (returns Result) and treating parse errors as "not blocked" to preserve prior behavior
  • src/lib.rs: Update #[pymodule] signature from (_py: Python, m: &PyModule) to (m: &Bound<'_, PyModule>) per PyO3 0.20+ requirements
  • src/lib.rs: Simplify check_network_urls return type from PyResult<bool> to bool — the method is now infallible; also clears a clippy useless_conversion warning
  • pyproject.toml: Bump version to 0.6.0 to match Cargo.toml

@simonirwin-r7

simonirwin-r7 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants