update build process for python>=3.8 - #11
Open
mchasse wants to merge 1 commit into
Open
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were done with Claude Code.
Upgrade to PyO3 0.22, adblock-rust 0.8, and abi3 wheel (Path B)
Cargo.toml: Bump version to0.6.0; upgrade PyO3 from0.16.5to0.22; upgrade adblock from0.5to0.8Cargo.toml: Add transitive pinrmp = ">=0.8, <0.8.15"to guard against a semver-breaking change inrmp 0.8.15that breaks adblock's transitive deprmp-serde 0.15.5— necessary becauseCargo.lockis gitignored for this librarysrc/lib.rs: ReplaceEngine::from_ruleswithFilterSet::new+FilterSet::add_filters+Engine::from_filter_set, matching the adblock 0.8 APIsrc/lib.rs: Replace removedEngine::check_network_urlswithcheck_network_request(&Request), building aRequestviaRequest::new(returnsResult) and treating parse errors as "not blocked" to preserve prior behaviorsrc/lib.rs: Update#[pymodule]signature from(_py: Python, m: &PyModule)to(m: &Bound<'_, PyModule>)per PyO3 0.20+ requirementssrc/lib.rs: Simplifycheck_network_urlsreturn type fromPyResult<bool>tobool— the method is now infallible; also clears a clippyuseless_conversionwarningpyproject.toml: Bump version to0.6.0to matchCargo.toml