Repository navigation
Categories for iHateMoney category servers + optional title-based suggestion - #105
Closed
modularidea wants to merge 8 commits into
Closed
modularidea wants to merge 8 commits into
modularidea wants to merge 8 commits into
Conversation
Why: forks of iHateMoney add bill categories; the app showed them only for Cospend. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Why: new user-facing options. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
modularidea
marked this pull request as draft
October 14, 2026 10:02
Why: Xcode re-sorted the entries of the new files on open. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Why: Xcode touched it during local builds; not part of this feature. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Why: one line is enough for a feature list. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Why: stock iHateMoney has no category field; categories are assigned and stored locally there. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Why: stock iHateMoney keeps categories on the device now. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Why: tags were plain gray text, and some built-in icons rendered as monochrome glyphs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
modularidea
marked this pull request as ready for review
October 14, 2026 11:10
Owner
|
Hi @modularidea! Thank you for your contribution. Unfortunately I must reject it for the following reasons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bill categories for iHateMoney, and an optional category suggestion from the bill title.
Upstream already shows/edits categories for Cospend. iHateMoney itself has no categories, but servers exist that add them wire-compatible with Cospend (
categoryid,paymentmodeid,/categories, and afeatureslist in the project info). This PR makes the app use them there. On a server without categories (the official one) the app keeps the category on the device instead. Nothing changes for Cospend.Changes
categoryidinfeatures):categoryid/paymentmodeidare sent with bills (""= none, since the form rejects0); the project's categories and payment modes are loaded. Cospend's built-in negative ids are offered in the picker next to the project's own, as these servers accept them without listing them.localBillCategorytable, migration v5). Not synced, lost on reinstall. The request to the server is identical to before.CategoryChip) instead of grey text. Emoji that default to text presentation (🌩 🛍) get the variation selector so they render in colour.Tests
testIHateMoney_loadTags_emitsEmptyWithoutSendingARequest(iHateMoney now reads the project info) by two tests: stock server → empty, category server → categories + features.PayForMeTestssuite passes locally (198 tests).ihatemoney.org(create bill, category kept locally and resolved) and a local category-enabled server in Docker (create, list, edit; categories in the list; suggestion in the bill form), in the simulator.Notes
Billhas no model for them yet).IPHONEOS_DEPLOYMENT_TARGET >= 15for the UI test target (14.0 in the project); not touched here.🤖 Generated with Claude Code