refactor filters and movers - #796
Merged
zyxkad merged 8 commits intoNov 22, 2025
Merged
Conversation
Contributor
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
fix fill implemention returns remaining instead of inserted
zyxkad
marked this pull request as ready for review
November 19, 2025 20:16
SirEndii
approved these changes
Nov 19, 2025
SirEndii
left a comment
Member
There was a problem hiding this comment.
Looks fine to me. Free to merge when you don't have anything to add.
1 of 2 tasks
Co-authored-by: programmer3481 <gwch3481@gmail.com>
zyxkad
marked this pull request as draft
November 21, 2025 02:53
do not throw exception when slot is out of range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
importFluidmethod can only import from first slot #794Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
Should not
Other information:
Fluid & chemical filter now will accept
amountinstead ofcount. The support ofcountfield should be removed in 0.8.