Repository navigation
fix(seg): try bulk data fetch for PerFrameFunctionalGroupsSequence before full Part 10 fallback - #152
Merged
Merged
Conversation
…fore full Part 10 fallback Before falling back to fetching the full DICOM Part 10 file when PerFrameFunctionalGroupsSequence is not inline, first check if the server provides it via BulkDataURI. If available, fetch the bulk data and parse it as JSON, then use the metadata-based loader. Loading strategy (in order of preference): 1. Inline PerFrameFunctionalGroupsSequence (array) → metadata-based loader 2. BulkDataURI for PerFrameFunctionalGroupsSequence → fetch bulk data, then metadata-based loader 3. No bulk data or fetch fails → buffer-based loader (full Part 10 file)
igoroctaviano
had a problem deploying
to
fork-pr-approval
October 6, 2026 14:32 — with 
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhancement to the SEG loading fallback to try fetching
PerFrameFunctionalGroupsSequencevia bulk data before falling back to the full Part 10 file.Context
This is a follow-up to PR #148 which added the fallback to buffer-based loader when
PerFrameFunctionalGroupsSequenceis missing from inline metadata.Based on feedback from @fedorov on the upstream OHIF PR (#6333), some servers may provide the sequence via BulkDataURI rather than inline. This is more efficient for large SEGs as it avoids including the entire sequence in the JSON metadata response.
Loading Strategy (in order of preference)
PerFrameFunctionalGroupsSequenceis present as array → use efficient metadata-based loaderPerFrameFunctionalGroupsSequencehasBulkDataURI→ fetch bulk data, parse JSON, then use metadata-based loaderChanges
PerFrameFunctionalGroupsSequencehas aBulkDataURIorretrieveBulkDatamethodRelated