This repository was archived by the owner on Jun 2, 2026. It is now read-only.
fix(socket): Properly cleanup Discord IPC socket on disconnect - #57
Merged
Conversation
- Add close() method to backend to disconnect Discord client on shutdown - Fix sockets.py disconnect() to reset socket to None after closing - Add try/except around socket shutdown/close for robustness This fixes the error that occurred when restarting StreamController: "failed to connect to socket /run/user/1000/discord-ipc-0, trying next socket. [Errno 106] Transport endpoint is already connected"
Owner
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When restarting StreamController without restarting Discord, the following error occurred:
Root Cause
The
disconnect()method insockets.pywas closing the socket but not resettingself.socket = None. Whenconnect()was called again, it tried to reuse the closed socket object instead of creating a fresh one.