Add tests for combine and koyo tag import tools - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
hmi_tags0/1/2.csv,koyo_tags.csv).Description
tests/test_combine_tools.pywhich exercises the CLI entrypoints via theirmain()functions (combine_tags_main,koyo_tags_import_main) using controlledsys.argvvalues.hmi_tags0.csvwithhmi_tags1.csv, convertingkoyo_tags.csvinto an EasyBuilder CSV, and importing/mergingkoyo_tags.csvintohmi_tags0.csv,hmi_tags1.csv, andhmi_tags2.csv.--force --strategy skipso runs are deterministic and non-interactive, and assertions check final list sizes and representative tag address/type outcomes (including an expected absent/skipped tag case).tests/test_combine_tools.py(adds the five tests and small helper runners that setsys.argv).Testing
pytest -q tests/test_combine_tools.pyand the new module passed (5 passed).pytest -qand all tests passed (23 passed).Codex Task