Repository navigation
fix: [WEB-002] QR scanner camera permission modal is not accessible to screen readers - #934
Merged
Merged
Conversation
|
@Eeboade Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Eeboade
force-pushed
the
solver/issue-859-29-a0
branch
from
October 21, 2026 12:01
02c3c67 to
1720322
Compare
Nanafancy
marked this pull request as ready for review
October 26, 2026 11:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The web frontend has no camera-permission gate or QR scanner:
QRCodeDisplayonly renders a code, and the send flow has no scanner. I added a reusableCameraPermissionDialog(ignition-pay-frontend/components/camera-permission-dialog.tsx) built on the shared Base UIDialog, so it getsrole=dialog,aria-modal, a focus trap and Escape to close. It has a labelled title and description, and arole=statusaria-live=politeregion that announces the permission state (prompt, requesting, granted, denied, unavailable). The primary 'Allow camera' / 'Try again' button is auto-focused and works from the keyboard, and Cancel closes the dialog. I did not wire it intoQRCodeDisplayorSendPage, because there is no scanner there yet. A future scanner should render this dialog and drive itsstateprop fromgetUserMediaresults. I couldn't run anything, so none of this has been run.Changed files
ignition-pay-frontend/components/camera-permission-dialog.tsxignition-pay-frontend/tests/camera-permission-dialog.test.tsxTest plan
New test
ignition-pay-frontend/tests/camera-permission-dialog.test.tsxchecks the dialog's name, description and aria-modal, the live status text, the allow button click, and that the allow button is hidden when no camera exists. CI should run the frontend vitest suite, plus lint and typecheck.This PR was created as a draft by the issue solver bot. It will remain a
draft until repository CI passes.
Closes #859