fix(cli): fix jQuery theme assets copy#1723
Merged
Merged
Conversation
|
coverage: 88.077% (+0.3%) from 87.809% — ganastasov/fix-jquery-theme-assets-copy into master |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the ig build flow for jQuery projects using .less / .sass themes by correctly copying theme assets when the theme contains directories (e.g., images/), resolving the failure described in #1718.
Changes:
- Update the build command to copy theme directories recursively (instead of attempting
copyFileSyncon directory entries). - Normalize theme source path construction using
path.join(...)segments. - Add a unit test that validates nested theme assets (like
images/foo.png) are copied into the projectthemes/directory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/unit/build-spec.ts | Adds a regression unit test ensuring theme folders (e.g., images/) are copied recursively for jQuery LESS themes. |
| packages/cli/lib/commands/build.ts | Fixes theme asset copying by using recursive directory copy when the theme source is a directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkalinovInfra
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the CLI build process for jQuery projects using LESS/SASS themes.
Previously, the build command copied theme directory entries using
fs.copyFileSync. This failed when one of the entries was a directory, such as theimagesfolder in theinfragistics.lesstheme.The fix uses recursive copying when the theme source is a directory, allowing all theme assets, including nested folders, to be copied correctly.
Related Issue
Closes #1718
Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context
The issue was reproduced with a jQuery project using the
infragistics.lesstheme.